Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override with 404 when returning response inside CompletableFuture #10501

Merged
merged 1 commit into from
Feb 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,25 @@
import io.micronaut.core.async.annotation.SingleResult;
import io.micronaut.http.HttpHeaders;
import io.micronaut.http.HttpRequest;
import io.micronaut.http.HttpResponse;
import io.micronaut.http.HttpStatus;
import io.micronaut.http.MediaType;
import io.micronaut.http.annotation.Body;
import io.micronaut.http.annotation.Consumes;
import io.micronaut.http.annotation.Controller;
import io.micronaut.http.annotation.Get;
import io.micronaut.http.annotation.Post;
import io.micronaut.http.annotation.Status;
import io.micronaut.http.tck.AssertionUtils;
import io.micronaut.http.tck.BodyAssertion;
import io.micronaut.http.tck.HttpResponseAssertion;
import org.junit.jupiter.api.Test;
import org.reactivestreams.Publisher;
import reactor.core.publisher.Mono;

import java.io.IOException;
import java.util.Objects;
import java.util.concurrent.CompletableFuture;

import static io.micronaut.http.tck.TestScenario.asserts;

Expand Down Expand Up @@ -142,6 +146,28 @@ void testRequestBodyFormDataNoBodyAnnotation() throws IOException {
.build()));
}

@Test
void testEmptyFuture() throws IOException {
asserts(SPEC_NAME,
HttpRequest.GET("/response-body/empty-future")
.header(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_FORM_URLENCODED),
(server, request) -> AssertionUtils.assertDoesNotThrow(server, request,
HttpResponseAssertion.builder()
.status(HttpStatus.OK)
.build()));
}

@Test
void testEmptySingleResultPublisher() throws IOException {
asserts(SPEC_NAME,
HttpRequest.GET("/response-body/empty-single-result")
.header(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_FORM_URLENCODED),
(server, request) -> AssertionUtils.assertDoesNotThrow(server, request,
HttpResponseAssertion.builder()
.status(HttpStatus.OK)
.build()));
}

@Controller("/response-body")
@Requires(property = "spec.name", value = SPEC_NAME)
static class BodyController {
Expand Down Expand Up @@ -195,6 +221,17 @@ Publisher<Point> postMany(@Body Publisher<Point> data) {
String postBytes(@Body byte[] bytes) {
return new String(bytes);
}

@Get(uri = "/empty-future")
CompletableFuture<HttpResponse<?>> emptyFuture() {
return CompletableFuture.completedFuture(HttpResponse.ok());
}

@Get(uri = "/empty-single-result")
@SingleResult
Publisher<HttpResponse<?>> emptySingleResult() {
return Mono.just(HttpResponse.ok());
}
}

@Introspected
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,7 @@ private CompletionStage<MutableHttpResponse<?>> fromCompletionStage(@NonNull Htt
return CompletableFuture.completedStage(newNotFoundError(request));
}
}
boolean explicitResponse = false;
if (asyncBody instanceof HttpResponse<?> httpResponse) {
mutableResponse = httpResponse.toMutableResponse();
final Argument<?> bodyArgument = routeInfo.getReturnType() // CompletionStage
Expand All @@ -706,14 +707,15 @@ private CompletionStage<MutableHttpResponse<?>> fromCompletionStage(@NonNull Htt
return mutableResponse.body(innerBody);
});
}
explicitResponse = true;
} else if (asyncBody instanceof HttpStatus status) {
mutableResponse = forStatus(routeInfo, status);
} else {
mutableResponse = forStatus(routeInfo, null)
.body(asyncBody);
}
if (mutableResponse.body() == null) {
if (routeInfo.isVoid()) {
if (routeInfo.isVoid() || explicitResponse) {
return CompletableFuture.completedStage(voidResponse(routeInfo));
}
return CompletableFuture.completedStage(newNotFoundError(request));
Expand Down
Loading