Function Server TCK: RequestFilterTest failing #926
Comments
graemerocher
pushed a commit
that referenced
this issue
Jun 18, 2024
This PR adds Micronaut Server TCK for Oracle Cloud Function HTTP. Currently, 10 of 188 tests (5%) fail. Fixes: * Making the request implementation mutable to support filters. * Allow empty response when an exception is thrown micronaut-servlet#737 * Add support for parsing form data and support empty values in the form data. * Support binding publisher when there is only one element. * Support binding body parts for JSON case (so binding JSON properties). * Fix reading cookies from headers. Created issues: Function Server TCK: Body has already been consumed exception #921 Function Server TCK: ControllerConstraintHandlerTest failing because of getBody() #925 Function Server TCK: RequestFilterTest failing #926
|
should be fixed by my change to #923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue description
The Server TCK was added in this PR: #920.
Currently
RequestFilterTestis failing.The reason is that the
BaseFilterProcessorexpects an instance ofServerHttpRequestthat can provide the body withByteBody byteBody()method: https://github.com/micronaut-projects/micronaut-core/blob/39818ada8f3cabbe17ee4d61e19e13e4e0d1fef4/http/src/main/java/io/micronaut/http/filter/BaseFilterProcessor.java#L93-L109. This is not possible in this case, because InputEvent expects body input stream to be consumed immediately instead of giving it for further use.In the #923 PR I added method
consumeBody(Function<InputStream, T>)but it won't work in this case.cc @yawkat
The text was updated successfully, but these errors were encountered: