Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Server TCK for Oracle Cloud Function HTTP #920

Merged
merged 14 commits into from
Jun 18, 2024

Conversation

andriy-dmytruk
Copy link
Contributor

@andriy-dmytruk andriy-dmytruk commented Jun 11, 2024

This PR adds Micronaut Server TCK for Oracle Cloud Function HTTP.

Currently, 10 of 188 tests (5%) fail.

Fixes:

  • Making the request implementation mutable to support filters.
  • Allow empty response when an exception is thrown micronaut-servlet#737
  • Add support for parsing form data and support empty values in the form data.
  • Support binding publisher when there is only one element.
  • Support binding body parts for JSON case (so binding JSON properties).
  • Fix reading cookies from headers.

Created issues:

@andriy-dmytruk
Copy link
Contributor Author

I think this is ready to be merged. 10 tests are failing now. The JSON error tests are not passing for any non-netty implementation. And the other tests are covered by separate issues.

@graemerocher graemerocher merged commit 7e2cf6c into 4.1.x Jun 18, 2024
1 check passed
@graemerocher graemerocher deleted the andriy/function-http-tck branch June 18, 2024 12:23
@graemerocher graemerocher added the type: improvement A minor improvement to an existing feature label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants