Allow to fail on primitives in constructor with failOnNullForPrimitives=true
#881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
approved these changes
Jun 26, 2024
graemerocher
added
the
type: improvement
yawkat
reviewed
Jun 26, 2024
serde-api/src/main/java/io/micronaut/serde/config/DeserializationConfiguration.java
Outdated
Show resolved
Hide resolved
yawkat
reviewed
Jun 26, 2024
| @@ -803,6 +817,7 @@ public static final class DerProperty<B, P> { | |||
| .orElse(null); | |||
| this.explicitlyRequired = annotationMetadata.booleanValue(SerdeConfig.class, SerdeConfig.REQUIRED) | |||
| .orElse(false); | |||
| this.explicitlyRequiredForConstructor = explicitlyRequired || argument.isPrimitive() && failOnNullForPrimitives; | |||
There was a problem hiding this comment.
Suggested change
| this.explicitlyRequiredForConstructor = explicitlyRequired || argument.isPrimitive() && failOnNullForPrimitives; | |
| this.explicitlyRequiredForConstructor = explicitlyRequired || (argument.isPrimitive() && failOnNullForPrimitives); |
There was a problem hiding this comment.
Why? Having trouble reading it?
There was a problem hiding this comment.
yes, no idea about the precedence rules for the logical operators
There was a problem hiding this comment.
Just like in math * / AND has a priority :D
yawkat
approved these changes
Jun 26, 2024
…ionConfiguration.java Co-authored-by: Jonas Konrad <jonas.konrad@oracle.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #880