generated from micronaut-projects/micronaut-project-template
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to fail on primitives in constructor with failOnNullForPrimitives=true
#881
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
doc-examples/example-kotlin-ksp/src/main/kotlin/example/NonNullDto.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package example | ||
|
|
||
| import io.micronaut.serde.annotation.Serdeable | ||
|
|
||
| @Serdeable | ||
| data class NonNullDto( | ||
| val longField: Long, | ||
| ) |
9 changes: 9 additions & 0 deletions
9
doc-examples/example-kotlin-ksp/src/main/kotlin/example/NullDto.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
|
|
||
| package example | ||
|
|
||
| import io.micronaut.serde.annotation.Serdeable | ||
|
|
||
| @Serdeable | ||
| data class NullDto( | ||
| val longField: Long? = null | ||
| ) |
9 changes: 9 additions & 0 deletions
9
doc-examples/example-kotlin-ksp/src/main/kotlin/example/NullPropertyDto.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
|
|
||
| package example | ||
|
|
||
| import io.micronaut.serde.annotation.Serdeable | ||
|
|
||
| @Serdeable | ||
| class NullPropertyDto { | ||
| var longField: Long? = null | ||
| } |
50 changes: 50 additions & 0 deletions
50
doc-examples/example-kotlin-ksp/src/test/kotlin/example/SerdeNullableFailOnMissingTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| package example | ||
|
|
||
| import io.micronaut.context.annotation.Property | ||
| import io.micronaut.json.JsonMapper | ||
| import io.micronaut.serde.exceptions.SerdeException | ||
| import io.micronaut.test.extensions.junit5.annotation.MicronautTest | ||
| import org.junit.jupiter.api.Assertions | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| @Property(name = "micronaut.serde.deserialization.failOnNullForPrimitives", value = "true") | ||
| @MicronautTest | ||
| class SerdeNullableFailOnMissingTest { | ||
|
|
||
| @Test | ||
| fun testDefaultValue(objectMapper: JsonMapper) { | ||
| val result = objectMapper.writeValueAsString(NullDto()) | ||
| val bean = objectMapper.readValue(result, NullDto::class.java) | ||
| Assertions.assertEquals(null, bean.longField) | ||
| } | ||
|
|
||
| @Test | ||
| fun testNonNullValue(objectMapper: JsonMapper) { | ||
| val e = Assertions.assertThrows(SerdeException::class.java) { | ||
| objectMapper.readValue("{}", NonNullDto::class.java) | ||
| } | ||
| Assertions.assertEquals( | ||
| "Unable to deserialize type [example.NonNullDto]. Required constructor parameter [long longField] at index [0] is not present or is null in the supplied data", | ||
| e.message | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun testNonNullValue2(objectMapper: JsonMapper) { | ||
| val e = Assertions.assertThrows(SerdeException::class.java) { | ||
| objectMapper.readValue("{\"longField\": null}", NonNullDto::class.java) | ||
| } | ||
| e.printStackTrace(); | ||
| Assertions.assertEquals( | ||
| "Unable to deserialize type [example.NonNullDto]. Required constructor parameter [long longField] at index [0] is not present or is null in the supplied data", | ||
| e.message | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun testNullPropertyValue(objectMapper: JsonMapper) { | ||
| val bean = objectMapper.readValue("{}", NullPropertyDto::class.java) | ||
| Assertions.assertEquals(null, bean.longField) | ||
| } | ||
|
|
||
| } |
36 changes: 36 additions & 0 deletions
36
doc-examples/example-kotlin-ksp/src/test/kotlin/example/SerdeNullableTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package example | ||
|
|
||
| import io.micronaut.json.JsonMapper | ||
| import io.micronaut.test.extensions.junit5.annotation.MicronautTest | ||
| import org.junit.jupiter.api.Assertions | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| @MicronautTest | ||
| class SerdeNullableTest { | ||
|
|
||
| @Test | ||
| fun testDefaultValue(objectMapper: JsonMapper) { | ||
| val result = objectMapper.writeValueAsString(NullDto()) | ||
| val bean = objectMapper.readValue(result, NullDto::class.java) | ||
| Assertions.assertEquals(null, bean.longField) | ||
| } | ||
|
|
||
| @Test | ||
| fun testNonNullValue(objectMapper: JsonMapper) { | ||
| val bean = objectMapper.readValue("{}", NonNullDto::class.java) | ||
| Assertions.assertEquals(0, bean.longField) | ||
| } | ||
|
|
||
| @Test | ||
| fun testNonNullValue2(objectMapper: JsonMapper) { | ||
| val bean = objectMapper.readValue("{\"longField\":null}", NonNullDto::class.java) | ||
| Assertions.assertEquals(0, bean.longField) | ||
| } | ||
|
|
||
| @Test | ||
| fun testNullPropertyValue(objectMapper: JsonMapper) { | ||
| val bean = objectMapper.readValue("{}", NullPropertyDto::class.java) | ||
| Assertions.assertEquals(null, bean.longField) | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? Having trouble reading it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, no idea about the precedence rules for the logical operators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like in math * / AND has a priority :D