Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate why Http Server Tck ErrorHandlerTest fails #376

Closed
sdelamo opened this issue Jan 16, 2023 · 3 comments · Fixed by #388
Closed

investigate why Http Server Tck ErrorHandlerTest fails #376

sdelamo opened this issue Jan 16, 2023 · 3 comments · Fixed by #388
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@timyates
Copy link
Contributor

For all 3 failures here, it seems the @Produces is ignored for the @Error handler methods, ie:

        @Error
        @Produces({"text/plain"})
        @Status(HttpStatus.OK)
        String localHandler(AnotherException throwable) {
            return throwable.getMessage();
        }

or

        @Error
        @Produces(io.micronaut.http.MediaType.TEXT_PLAIN)
        @Status(HttpStatus.OK)
        String localHandler(AnotherException throwable) {
            return throwable.getMessage();
        }

Has the correct response, but it isn't text-plain

@sdelamo
Copy link
Contributor Author

sdelamo commented Jan 16, 2023

Right, that looks like a bug.

@sdelamo sdelamo added the type: bug Something isn't working label Jan 16, 2023
@timyates timyates added this to the 3.3.4 milestone Jan 17, 2023
@sdelamo
Copy link
Contributor Author

sdelamo commented Jan 20, 2023

@timyates can we close this?

sdelamo added a commit that referenced this issue Jan 20, 2023
Close #/378
Close #377
Close #376
@sdelamo sdelamo linked a pull request Jan 20, 2023 that will close this issue
sdelamo added a commit that referenced this issue Jan 20, 2023
Close #/378
Close #377
Close #376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants