Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content Type from Error handler should be respected #382

Merged
merged 5 commits into from
Jan 19, 2023
Merged

Content Type from Error handler should be respected #382

merged 5 commits into from
Jan 19, 2023

Conversation

timyates
Copy link
Contributor

This change will apply the first non-json content type to a response from a route match.

This means that Error handlers will respect any @provides annotation

Closes #376

@timyates
Content Type from Error handler should be respected
78cb93f 
This change will apply the first non-json content type to a response from a route match.

This means that Error handlers will respect any @provides annotation
@timyates timyates added the type: bug Something isn't working label Jan 17, 2023
@timyates timyates added this to the 3.3.4 milestone Jan 17, 2023
@timyates timyates requested review from sdelamo and yawkat January 17, 2023 16:33
@timyates timyates self-assigned this Jan 17, 2023
yawkat
yawkat approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@yawkat yawkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a hack but ok

@timyates
Copy link
Contributor Author

seems like a hack but ok

I believe a lot of this machinery has gone away for 4.0.x, and I couldn't find a better way of doing it 🫣

Let me check master for the TCK test for Error and see if I'm right...

@timyates
Copy link
Contributor Author

timyates commented Jan 17, 2023 •
edited
Loading

So yes, in the master branch (once the TCK is merged), we get the correct response type

But a different error of Exception: Multiple possible bean candidates found: [CodecErrorHandler, CodecExceptionExceptionHandler] 😿

@timyates timyates requested a review from yawkat January 17, 2023 17:29
@timyates
Copy link
Contributor Author

@yawkat Hopefully found a less hacky way

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell E 33 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@sdelamo sdelamo merged commit 2fa6e97 into 3.3.x Jan 19, 2023
@sdelamo sdelamo deleted the fix-error-produces branch January 19, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yawkat yawkat yawkat approved these changes

@sdelamo sdelamo sdelamo approved these changes

@graemerocher graemerocher graemerocher approved these changes

Assignees

@timyates timyates

Labels
type: bug Something isn't working
Projects
None yet
Milestone
3.3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@timyates @graemerocher @sdelamo @yawkat