PartialSuccessTransmissionPolicy: Avoid unnecessary content deserializations

[vangarp]

Fix Issue #2445 by only deserializing the content at the point in time when we absolutely must.

Changes

(Please provide a brief description of the changes here.)

Checklist

• I ran Unit Tests locally.
• CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

• Design discussion issue #
• Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

• FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

• We support comment build triggers
  • /AzurePipelines run will queue all builds
  • /AzurePipelines run <pipeline-name> will queue a specific build

[TimothyMothra]

On the whole, i like this change to defer the Json Deserialization until it's needed.
The only problem i see is that the deserialization happens inside the foreach and could be run multiple times.
We may need to cache this deserialization.

[vangarp]

On the whole, i like this change to defer the Json Deserialization until it's needed.
The only problem i see is that the deserialization happens inside the foreach and could be run multiple times.
We may need to cache this deserialization.

Absolutely…..created in a hurry and missed this. Will make the necessary changes

[TimothyMothra]

LGTM. Can you please move your changelog entry under the VNext section?

[TimothyMothra]

I see a bunch of "retrigger checks" commits. Don't worry about that.
We have a handful of tests that are flaky, I can re-queue a subset of tests without retrigging all of them.

[TimothyMothra]

@vangarp, this just merged. Thank you for your patience.

Setting expectations for the future,
We don't currently have a date planned for the 2.21 milestone.
2.21-beta1 will likely be by the end of January.
We just missed the cutoff for today's nightly build, but this change will be in tomorrow's nightly.

[vangarp]

@vangarp, this just merged. Thank you for your patience.

Setting expectations for the future, We don't currently have a date planned for the 2.21 milestone. 2.21-beta1 will likely be by the end of January. We just missed the cutoff for today's nightly build, but this change will be in tomorrow's nightly.

Thank you so much! Ack on the dates