Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartialSuccessTransmissionPolicy: Avoid unnecessary content deserializations #2446

Conversation

vangarp
Copy link
Contributor

@vangarp vangarp commented Oct 20, 2021

Fix Issue #2445 by only deserializing the content at the point in time when we absolutely must.

Changes

(Please provide a brief description of the changes here.)

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@TimothyMothra
Copy link
Member

@vangarp please update the changelog under the VNext section

@vangarp
Copy link
Contributor Author

vangarp commented Oct 20, 2021

@vangarp please update the changelog under the VNext section

done

@TimothyMothra
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 2 pipeline(s).

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2446 in repo microsoft/ApplicationInsights-dotnet

@TimothyMothra
Copy link
Member

Hello @vangarp ,
Just an FYI; we're going to hold this PR for a few weeks.
Because this touches the TelemetryChannel, we consider this a critical change and want more time to review it.
We have some internal deadlines to meet for the 2.19 Release and we don't want to rush any new code changes.
Sorry for the inconvenience.

@TimothyMothra TimothyMothra added this to the 2.20 milestone Oct 21, 2021
@vangarp
Copy link
Contributor Author

vangarp commented Oct 21, 2021

I understand. Thanks for letting me know

* Update Readme.md

* update branch in build definitions
* testing pipelines

* testing collecting build output

* test nupkg

* testing different path

* testing bin directory

* test: do artifacts support wildcards?

* testing signing DLLs

* add missing build flags

* testing two part build/pack

* testing pack cmd

* testing pack in package step

* testing different signing profile

* testing external_distribution

* cleanup

* testing placeholder for testing

* testing multiple pipelines

* rename everything

* update pipelines with custom hello world for runtime logging

* fix args

* testing unique build params

* one more to fix pack for buddy

* testing consolidating cmd files

* cleanup

* changing slashes
* testing moving sdl options to common file

* testing config

* remove extra config
* new builds for other solutions

* fix name

* remove ubuntu

* typo

* testing additional frameworks

* typo

* test, remove exclude

* full framework coverage

* cleanup

* cleanup

* typo
* update sanity workflow

* typo
* fix analyzers

* add Test.props to these extra projects

* cleanup obsolete warnings
@TimothyMothra TimothyMothra modified the milestones: 2.20, 2.21 Dec 14, 2021
TimothyMothra and others added 3 commits December 14, 2021 14:58
* testing release metadata

* testing powershell

* testing powershell

* testing powershell

* testing powershell

* testing powershell

* testing argument names
* initial script. this is working as expected

* update for every package name

* update

* null check

Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
@TimothyMothra
Copy link
Member

Hi @vangarp,
Can you please recreate this PR to target the main branch?

I'm sorry this PR has gotten held up.
I've had a series of competing deadlines since Oct, one of which was a mandate to rebuild our build pipelines.
I would be happy to explain if you want to know.

@vangarp
Copy link
Contributor Author

vangarp commented Dec 17, 2021

@TimothyMothra created #2500

@vangarp vangarp closed this Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants