-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PartialSuccessTransmissionPolicy: Avoid unnecessary content deserializations #2446
PartialSuccessTransmissionPolicy: Avoid unnecessary content deserializations #2446
Conversation
…absolutely needed
@vangarp please update the changelog under the VNext section |
done |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 2 pipeline(s). |
Commenter does not have sufficient privileges for PR 2446 in repo microsoft/ApplicationInsights-dotnet |
…absolutely needed
…ttps://github.com/vangarp/ApplicationInsights-dotnet into vangarp/optimize-partialsuccessretransmissionpolicy
Hello @vangarp , |
I understand. Thanks for letting me know |
* Update Readme.md * update branch in build definitions
* testing pipelines * testing collecting build output * test nupkg * testing different path * testing bin directory * test: do artifacts support wildcards? * testing signing DLLs * add missing build flags * testing two part build/pack * testing pack cmd * testing pack in package step * testing different signing profile * testing external_distribution * cleanup * testing placeholder for testing * testing multiple pipelines * rename everything * update pipelines with custom hello world for runtime logging * fix args * testing unique build params * one more to fix pack for buddy * testing consolidating cmd files * cleanup * changing slashes
* testing moving sdl options to common file * testing config * remove extra config
* new builds for other solutions * fix name * remove ubuntu * typo * testing additional frameworks * typo * test, remove exclude * full framework coverage * cleanup * cleanup * typo
* update sanity workflow * typo
* fix analyzers * add Test.props to these extra projects * cleanup obsolete warnings
* testing release metadata * testing powershell * testing powershell * testing powershell * testing powershell * testing powershell * testing argument names
* initial script. this is working as expected * update for every package name * update * null check Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
Hi @vangarp, I'm sorry this PR has gotten held up. |
@TimothyMothra created #2500 |
Fix Issue #2445 by only deserializing the content at the point in time when we absolutely must.
Changes
(Please provide a brief description of the changes here.)
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines run
will queue all builds/AzurePipelines run <pipeline-name>
will queue a specific build