Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AppInsights Profiler support in base workspace bundle #2478

Merged
merged 12 commits into from
Aug 22, 2022

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Aug 18, 2022

What is being addressed

We have some support for App Insights Profiler but that will likely not work or even needed.

How is this addressed

  • Deploy App Insights in the base workspace to use native resources (rather than ARM).
  • Remove support of the Profiler
  • Support internet ingestion when debugging locally (core & workspace)
  • Add terraform validate to bundle-build to make errors visible locally quicker

@github-actions
Copy link

github-actions bot commented Aug 18, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 8ec044e.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara force-pushed the tamirkamara/app-insights-changes branch from e903589 to 9579ce5 Compare August 21, 2022 13:11
@tamirkamara tamirkamara marked this pull request as ready for review August 21, 2022 13:26
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2898632205 (with refid 2567da6c)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2898673257 (with refid 2567da6c)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) August 21, 2022 15:50
Copy link
Contributor

@stuartleeks stuartleeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tamirkamara tamirkamara merged commit d19ef55 into main Aug 22, 2022
@tamirkamara tamirkamara deleted the tamirkamara/app-insights-changes branch August 22, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants