Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AppInsights Profiler support in base workspace bundle #2478

Merged
merged 12 commits into from
Aug 22, 2022
10 changes: 6 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,16 @@

FEATURES:

* MySql workspace service ([#2476](https://github.com/microsoft/AzureTRE/issues/2476))
* MySql workspace service ([#2476](https://github.com/microsoft/AzureTRE/pull/2476))

ENHANCEMENTS:

* 'CreationTime' field was added to Airlock requests ([#2432](https://github.com/microsoft/AzureTRE/issues/2432))
* 'CreationTime' field was added to Airlock requests ([#2432](https://github.com/microsoft/AzureTRE/pull/2432))
* Bundles mirror Terraform plugins when built ([#2446](https://github.com/microsoft/AzureTRE/pull/2446))
* 'Get all Airlock requests' endpoint supports filtering ([#2433](https://github.com/microsoft/AzureTRE/pull/2433)).
* API uses user delagation key when generating SAS token for airlock requests. ([#2390](https://github.com/microsoft/AzureTRE/issues/2390))
* 'Get all Airlock requests' endpoint supports filtering ([#2433](https://github.com/microsoft/AzureTRE/pull/2433))
* API uses user delagation key when generating SAS token for airlock requests ([#2460](https://github.com/microsoft/AzureTRE/pull/2460))
* Longer docker caching in Resource Processor ([#2486](https://github.com/microsoft/AzureTRE/pull/2486))
* Remove AppInsights Profiler support in base workspace bundle and deploy with native Terraform resources ([#2478](https://github.com/microsoft/AzureTRE/pull/2478))

BUG FIXES:

Expand Down
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ bundle-build:
&& . ${MAKEFILE_DIR}/devops/scripts/load_env.sh ${DIR}/.env \
&& . ${MAKEFILE_DIR}/devops/scripts/set_docker_sock_permission.sh \
&& cd ${DIR} \
&& if [ -d terraform ]; then terraform -chdir=terraform init -backend=false; terraform -chdir=terraform validate; fi \
&& FULL_IMAGE_NAME_PREFIX=${FULL_IMAGE_NAME_PREFIX} IMAGE_NAME_PREFIX=${IMAGE_NAME_PREFIX} \
${MAKEFILE_DIR}/devops/scripts/bundle_runtime_image_build.sh \
&& porter build --debug
Expand Down
4 changes: 2 additions & 2 deletions templates/core/terraform/azure-monitor/azure-monitor.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ resource "azurerm_log_analytics_workspace" "core" {
retention_in_days = 30
sku = "PerGB2018"
tags = var.tre_core_tags
internet_ingestion_enabled = false
internet_ingestion_enabled = var.enable_local_debugging ? true : false

lifecycle { ignore_changes = [tags] }
}
Expand Down Expand Up @@ -65,7 +65,7 @@ resource "azurerm_application_insights" "core" {
resource_group_name = var.resource_group_name
workspace_id = azurerm_log_analytics_workspace.core.id
application_type = "web"
internet_ingestion_enabled = false
internet_ingestion_enabled = var.enable_local_debugging ? true : false
force_customer_storage_for_profiler = true
tags = var.tre_core_tags

Expand Down
1 change: 1 addition & 0 deletions templates/core/terraform/azure-monitor/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ variable "azure_monitor_ods_opinsights_dns_zone_id" {}
variable "azure_monitor_agentsvc_dns_zone_id" {}
variable "blob_core_dns_zone_id" {}
variable "tre_core_tags" {}
variable "enable_local_debugging" {}
1 change: 1 addition & 0 deletions templates/core/terraform/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ module "azure_monitor" {
azure_monitor_agentsvc_dns_zone_id = module.network.azure_monitor_agentsvc_dns_zone_id
blob_core_dns_zone_id = module.network.blob_core_dns_zone_id
tre_core_tags = local.tre_core_tags
enable_local_debugging = var.enable_local_debugging

depends_on = [
module.network
Expand Down
2 changes: 1 addition & 1 deletion templates/core/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.4.16"
__version__ = "0.4.17"
2 changes: 1 addition & 1 deletion templates/workspaces/base/porter.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: tre-workspace-base
version: 0.3.24
version: 0.3.25
description: "A base Azure TRE workspace"
dockerfile: Dockerfile.tmpl
registry: azuretre
Expand Down
64 changes: 0 additions & 64 deletions templates/workspaces/base/terraform/azure-monitor/ampls.json

This file was deleted.

This file was deleted.

Loading