Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core infra terraform templates #49

Merged
merged 11 commits into from
May 10, 2021
Merged

Conversation

deniscep
Copy link
Contributor

@deniscep deniscep commented May 7, 2021

Add core infra terraform templates

What is being addressed

  • Implement a set of terraform templates to create TRE Management core as described in infra diagram

How is this addressed

  • Added terraform modules for VNET, Subnets, Keyvault, Firewall, S AppGateway, ACR, private DNS, and API Web App (22 resources and 1 resource group provisioned)
  • Subnets are delegated/dedicated as specified in infra
  • Private endpoints are provisioned for resources on private link, and private DNS is associated with VNET
  • Standardized naming convention to "resource abbreviation"-"prefix"-"environment"-"unique-random-id" (e.g. rg-tre-dev-0001)
  • Route table is provisioned and associated with Shared subnet, with default 0.0.0.0 route pointing to firewall
  • Added tfvars template with sample defaults

Out of scope for this PR:

  • hooking up app gateway to app service (pending decision on deployment implementation)
  • no firewall rules are added at this time (pending decision on exceptions)
  • deployment/composition service resources are not provisioned (pending decision on Porter)
  • Gitea & Nexus are not provisioned (pending decision on ACI vs VM)

Closes 5465 in AzDO

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments from a quick review of tf on my mobile. Some things might need pushing into other issues.

Have naming conventions been considered?

Great to see this making progress.

Copy link
Contributor

@sachinkundu sachinkundu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR :D
Looks good if it works.

templates/core/terraform/api-webapp/api-webapp.tf Outdated Show resolved Hide resolved
@deniscep deniscep merged commit 28d8a1e into develop May 10, 2021
@christoferlof christoferlof deleted the feature/5465-base-templates branch May 10, 2021 18:22
tim-allen-ck pushed a commit to CloudKubed/AzureTRE that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants