Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Got warning when use implicit launch type. #6836

Closed
python3kgae opened this issue Jul 30, 2024 · 0 comments · Fixed by #6837
Closed

Got warning when use implicit launch type. #6836

python3kgae opened this issue Jul 30, 2024 · 0 comments · Fixed by #6837
Labels
bug Bug, regression, crash needs-triage Awaiting triage

Comments

@python3kgae
Copy link
Contributor

Description

By default, the launch type should be set to ‘Broadcast’ when diagnosing barriers.
However, the current behavior sets the default launch type to ‘Invalid,’ resulting in warnings when the launch type is not explicitly specified as an attribute.
Steps to Reproduce

https://godbolt.org/z/MescEbMcq

Actual Behavior

Warning is reported which should not.

Environment

  • DXC version 1.8.2407
  • Host Operating System : Windows.
@python3kgae python3kgae added bug Bug, regression, crash needs-triage Awaiting triage labels Jul 30, 2024
@python3kgae python3kgae mentioned this issue Jul 30, 2024
Merged
@python3kgae python3kgae mentioned this issue Jul 31, 2024
Merged
python3kgae added a commit that referenced this issue Jul 31, 2024
@python3kgae
Fix warning when use implicit launch type. (#6837) (#6841)
416fab6 
By default, the launch type should be set to ‘Broadcast’ when diagnosing
barriers. However, the current behavior sets the default launch type to
‘Invalid,’ resulting in warnings when the launch type is not explicitly
specified as an attribute.

To address this issue, we’ll adjust the default setting to ‘Broadcast’
and thereby resolve the problem.

Fixes #6836

---------

Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
(cherry picked from commit ef043e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug, regression, crash needs-triage Awaiting triage
Projects
HLSL Triage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix warning when use implicit launch type. python3kgae/DirectXShaderCompiler
1 participant
@python3kgae