Fix warning when use implicit launch type. #6837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the launch type should be set to ‘Broadcast’ when diagnosing barriers. However, the current behavior sets the default launch type to ‘Invalid,’ resulting in warnings when the launch type is not explicitly specified as an attribute. To address this issue, we’ll adjust the default setting to ‘Broadcast’ and thereby resolve the problem.
damyanp
reviewed
Jul 30, 2024
tools/clang/test/SemaHLSL/hlsl/intrinsics/barrier/barrier-node-errors.hlsl
Outdated
Show resolved
Hide resolved
damyanp
approved these changes
Jul 30, 2024
tools/clang/test/SemaHLSL/hlsl/intrinsics/barrier/barrier-node-errors.hlsl
Outdated
Show resolved
Hide resolved
…-errors.hlsl Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
bogner
approved these changes
Jul 30, 2024
tex3d
reviewed
Jul 30, 2024
python3kgae
added a commit
that referenced
this pull request
Jul 31, 2024
By default, the launch type should be set to ‘Broadcast’ when diagnosing barriers. However, the current behavior sets the default launch type to ‘Invalid,’ resulting in warnings when the launch type is not explicitly specified as an attribute. To address this issue, we’ll adjust the default setting to ‘Broadcast’ and thereby resolve the problem. Fixes #6836 --------- Co-authored-by: Damyan Pepper <damyanp@microsoft.com> (cherry picked from commit ef043e9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the launch type should be set to ‘Broadcast’ when diagnosing barriers. However, the current behavior sets the default launch type to ‘Invalid,’ resulting in warnings when the launch type is not explicitly specified as an attribute.
To address this issue, we’ll adjust the default setting to ‘Broadcast’ and thereby resolve the problem.
Fixes #6836