added editorconfig #2403
added editorconfig #2403
Conversation
There was a problem hiding this comment.
@StrikerRUS looks good to me! I just had one recommendation about handling indentation in Makefiles.
| indent_size = 2 | ||
|
|
||
| [*.{py,sh,js}] | ||
| indent_size = 4 |
There was a problem hiding this comment.
😆 one day @Laurae2 and I will agree on indents for .R. But today is not that day.
| charset=utf-8 | ||
| trim_trailing_whitespace = true | ||
| insert_final_newline = true | ||
| indent_style = space |
There was a problem hiding this comment.
We have two makefiles in the R package currently (part of the way you use R libraries that link to compiled code)
actually, I think it needs to be
# tabs matter for makefiles
[*{Makefile,Makevars,Makevars.win}]
indent_style = tab
There was a problem hiding this comment.
oh I guess they are currently empty...well better to be safe. There is also https://github.com/microsoft/LightGBM/blob/master/docs/Makefile and (now that I'm looking in the sphinx stuff), it should probably be:
# tabs matter for makefiles
[*{Makefile,make.bat,Makevars,Makevars.win}]
indent_style = tab
Yeah, me too! 😃 Thanks a lot for your very important remark about |
| insert_final_newline = none | ||
|
|
||
| # Tabs matter for Makefile and .gitmodules | ||
| [{makefile*,Makefile*,*.mk,*.mak,*.makefile,*.Makefile,GNUmakefile,BSDmakefile,make.bat,Makevars*,*.gitmodules}] |
There was a problem hiding this comment.
so comprehensive! Amazing, thank you
|
@guolinke Don't you know any other files that need special treatment? |
|
@StrikerRUS I think no |
Closed #2401.