Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] fixed R Dataset aliases #2775

Merged
merged 3 commits into from
Feb 19, 2020
Merged

[R-package] fixed R Dataset aliases #2775

merged 3 commits into from
Feb 19, 2020

Conversation

StrikerRUS
Copy link
Collaborator

Refer to #2594.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StrikerRUS ! Honestly can't believe I didn't make more mistakes, manually entering these from the docs

R-package/R/aliases.R Outdated Show resolved Hide resolved
Co-Authored-By: James Lamb <jaylamb20@gmail.com>
@StrikerRUS
Copy link
Collaborator Author

@jameslamb

Honestly can't believe I didn't make more mistakes, manually entering these from the docs

I even cannot remember how many times I checked that for Python! Maybe 5?.. 😃

That's why we have #2633.

@jameslamb
Copy link
Collaborator

This looks good to me! Feel free to merge once the build is green

@StrikerRUS StrikerRUS merged commit 25d149d into master Feb 19, 2020
@StrikerRUS StrikerRUS deleted the r_aliases branch February 19, 2020 13:16
@StrikerRUS StrikerRUS added fix and removed maintenance labels Mar 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants