[python][scikit-learn] add new attribute for used number of features #3129
Conversation
Fixes issue related to scikit-learn/scikit-learn#17353 (see SLEP010 https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest/slep010/proposal.html).
a-wozniakowski
requested review from
chivee,
henry0312,
StrikerRUS and
wxchan
as code owners
StrikerRUS
changed the title
There was a problem hiding this comment.
@a-wozniakowski Thanks a lot for your contribution!
To not break the backward compatibility with older scikit-learn versions n_features_ property should be left.
Also, it seems that the current implementation doesn't pass API test and fails at this line:
https://github.com/scikit-learn/scikit-learn/blob/7cc815c21c60dabe8252b30ada77621b88e2136c/sklearn/utils/estimator_checks.py#L2946
I guess that n_features_in_ should be set as an attribute in fit() method, not as property:
Make sure that n_features_in_ attribute doesn't exist until fit is called
Reverted ```n_features``` property, and inserted the public attribute ```n_features_in_```.
|
@StrikerRUS thanks!
|
There was a problem hiding this comment.
I see, thank you for the explanation!
Now please document new attribute near n_features_ description and I think we are ready to merge.
LightGBM/python-package/lightgbm/sklearn.py
Lines 258 to 259 in bcbf252
StrikerRUS
changed the title
…icrosoft#3129) * update number of features attribute Fixes issue related to scikit-learn/scikit-learn#17353 (see SLEP010 https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest/slep010/proposal.html). * Update sklearn.py * set public attribute in fit method Reverted ```n_features``` property, and inserted the public attribute ```n_features_in_```. * Update documentation * Update python-package/lightgbm/sklearn.py Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
…icrosoft#3129) * update number of features attribute Fixes issue related to scikit-learn/scikit-learn#17353 (see SLEP010 https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest/slep010/proposal.html). * Update sklearn.py * set public attribute in fit method Reverted ```n_features``` property, and inserted the public attribute ```n_features_in_```. * Update documentation * Update python-package/lightgbm/sklearn.py Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Fixes issue related to #17353 in scikit-learn (see SLEP010 for further details).