-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python][scikit-learn] new stacking tests and make number of features a property #3173
[python][scikit-learn] new stacking tests and make number of features a property #3173
Conversation
|
Please clarify why was it needed? Refer to #3129 (review). |
The change leaves |
@a-wozniakowski Please note that making
Please revert this and leave only new tests in this PR. |
@StrikerRUS I'm fine to revert the code, but I don't see the issue:
If one tries to access |
Ah, I see! That test can be passed due to the Please rebase this PR to current |
Update master
Split number of features and stacking tests.
Modify test name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-wozniakowski Thanks for the updates!
Please see some initial review comments below:
Update stacking tests for review comments.
Check score.
@StrikerRUS thanks for the feedback. #3192 encountered the same issue in |
Seems it was something different. I re-run that job for this PR and everything is OK now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-wozniakowski Thank you very much for your contribution!
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
In
python_package_test
, two stacking tests for classification and regression check LightGBM 's stacking layer compatibility (which is related to #17353).Also,
n_features_in_
has become a property, which updates #3129.