-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] upgrade R to 4.1.0 in CI #4328
Conversation
@@ -65,8 +65,8 @@ if ($env:R_MAJOR_VERSION -eq "3") { | |||
$RTOOLS_INSTALL_PATH = "C:\rtools40" | |||
$env:RTOOLS_BIN = "$RTOOLS_INSTALL_PATH\usr\bin" | |||
$env:RTOOLS_MINGW_BIN = "$RTOOLS_INSTALL_PATH\mingw64\bin" | |||
$env:RTOOLS_EXE_FILE = "rtools40-x86_64.exe" | |||
$env:R_WINDOWS_VERSION = "4.0.5" | |||
$env:RTOOLS_EXE_FILE = "rtools40v2-x86_64.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah! thanks for checking https://cran.r-project.org/bin/windows/Rtools/, I didn't realize this release came with a new version of RTools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versioning scheme in R ecosystem is so weird!
R version is 4.1
now but repo name is still cran40
and Rtools name is rtools40v2
while I remember they used to release new Rtools versions under the same name before.
On https://cran.r-project.org/bin/windows/Rtools/history.html I can't find anything about v2
version.
Still
Frozen? | No
for rtools40-x86_64.exe
.
PS. 10 days have passed after the release R version 4.1.0 (2021-05-18)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes these inconsistencies make it difficult sometimes to automate things in R haha. I looked too and have no idea why a v2
rtools was built, instead of just versioning it the same as R.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Seems most CI jobs are passing (I'm writing this before all have run), so the changes mentioned #3763 (comment) don't seem to have impacted {lightgbm}
.
By the way, it's difficult to tell just by looking at https://cran.r-project.org/web/checks/check_results_lightgbm.html but CRAN has been testing {lightgbm}
against R 4.1.0. See, for example, the logs from https://www.r-project.org/nosvn/R.check/r-patched-linux-x86_64/lightgbm-00check.html
using R version 4.1.0 Patched (2021-05-25 r80393)
using platform: x86_64-pc-linux-gnu (64-bit)
using session charset: UTF-8
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
No description provided.