Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] upgrade R to 4.1.0 in CI #4328

Merged
merged 4 commits into from
May 28, 2021
Merged

[ci] upgrade R to 4.1.0 in CI #4328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
650b6da
Update test_r_package_windows.ps1
StrikerRUS May 28, 2021
1f0da52
Update test_r_package.sh
StrikerRUS May 28, 2021
cb2ba20
Update r_package.yml
StrikerRUS May 28, 2021
cb9ce5a
Update r_package.yml
StrikerRUS May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ci/test_r_package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ if [[ "${R_MAJOR_VERSION}" == "3" ]]; then
export R_LINUX_VERSION="3.6.3-1bionic"
export R_APT_REPO="bionic-cran35/"
elif [[ "${R_MAJOR_VERSION}" == "4" ]]; then
export R_MAC_VERSION=4.0.5
export R_LINUX_VERSION="4.0.5-1.2004.0"
export R_MAC_VERSION=4.1.0
export R_LINUX_VERSION="4.1.0-1.2004.0"
export R_APT_REPO="focal-cran40/"
else
echo "Unrecognized R version: ${R_VERSION}"
Expand Down
4 changes: 2 additions & 2 deletions .ci/test_r_package_windows.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ if ($env:R_MAJOR_VERSION -eq "3") {
$RTOOLS_INSTALL_PATH = "C:\rtools40"
$env:RTOOLS_BIN = "$RTOOLS_INSTALL_PATH\usr\bin"
$env:RTOOLS_MINGW_BIN = "$RTOOLS_INSTALL_PATH\mingw64\bin"
$env:RTOOLS_EXE_FILE = "rtools40-x86_64.exe"
$env:R_WINDOWS_VERSION = "4.0.5"
$env:RTOOLS_EXE_FILE = "rtools40v2-x86_64.exe"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! thanks for checking https://cran.r-project.org/bin/windows/Rtools/, I didn't realize this release came with a new version of RTools

Copy link
Collaborator Author

@StrikerRUS StrikerRUS May 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versioning scheme in R ecosystem is so weird!
R version is 4.1 now but repo name is still cran40 and Rtools name is rtools40v2 while I remember they used to release new Rtools versions under the same name before.
On https://cran.r-project.org/bin/windows/Rtools/history.html I can't find anything about v2 version.
Still

Frozen? | No

for rtools40-x86_64.exe.

PS. 10 days have passed after the release R version 4.1.0 (2021-05-18).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes these inconsistencies make it difficult sometimes to automate things in R haha. I looked too and have no idea why a v2 rtools was built, instead of just versioning it the same as R.

$env:R_WINDOWS_VERSION = "4.1.0"
} else {
Write-Output "[ERROR] Unrecognized R version: $env:R_VERSION"
Check-Output $false
Expand Down