-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Guolin's e-mail in setup.py
#4663
Conversation
python-package/setup.py
Outdated
@@ -350,7 +350,7 @@ def run(self) -> None: | |||
], | |||
}, | |||
maintainer='Guolin Ke', | |||
maintainer_email='guolin.ke@microsoft.com', | |||
maintainer_email='guolin.ke@outlook.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks for catching this! Sorry I didn't think of it on #4633. Thankfully it's not as critical with PyPI as it is with CRAN.
@shiyu1994 should this be changed to your name and email? My assumption is that Microsoft would prefer to have a Microsoft employee as the primary contact for these artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Please change it to my information. Yu Shi and yushi2@microsoft.com. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Done in 1f3326c.
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Similar to fa4ecf4#diff-99c1b03acafa469ec3315aee841d2b64f122907ff1ebef7e7be5c793faf5bf0dR8.
Sorry, forgot about this field, noticed only during releasing new version at PyPI. Should have updated it during
v3.3.0
release 🤦♂️