Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Guolin's e-mail in setup.py #4663

Merged
merged 2 commits into from
Oct 13, 2021
Merged

update Guolin's e-mail in setup.py #4663

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea62f1f
update Guolin's e-mail in `setup.py`
StrikerRUS Oct 9, 2021
1f3326c
change maintainer's info
StrikerRUS Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python-package/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ def run(self) -> None:
],
},
maintainer='Guolin Ke',
maintainer_email='guolin.ke@microsoft.com',
maintainer_email='guolin.ke@outlook.com',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for catching this! Sorry I didn't think of it on #4633. Thankfully it's not as critical with PyPI as it is with CRAN.

@shiyu1994 should this be changed to your name and email? My assumption is that Microsoft would prefer to have a Microsoft employee as the primary contact for these artifacts.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Please change it to my information. Yu Shi and yushi2@microsoft.com. Thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Done in 1f3326c.

zip_safe=False,
cmdclass={
'install': CustomInstall,
Expand Down