Improve warning wordings #4731
Improve warning wordings #4731
Conversation
StrikerRUS
requested review from
btrotta,
chivee,
guolinke and
shiyu1994
as code owners
|
@hzy46 Could you please take a look at this?
It seems to me suggesting using integer values for label index and then clarifying that any values will be simply ignored doesn't make a lot of sense. WDYT? |
| } | ||
|
|
||
| if (config_.label_column != "") { | ||
| Log::Warning("Config label_column works only in case of loading data directly from text file. It will be ignored when loading from binary file."); | ||
| Log::Warning("Parameter label_column works only in case of loading data directly from text file. It will be ignored when loading from binary file."); |
There was a problem hiding this comment.
@hzy46 Could you please take a look at this?
Also, IMHO these two messages look contradictory:
#4731 (comment)It seems to me suggesting using integer values for label index and then clarifying that any values will be simply ignored doesn't make a lot of sense. WDYT?
For this case, maybe we can just skip the check for that label_idx_ is consistent? Since warning for a non-empty label_column is given subsequently here anyway.
There was a problem hiding this comment.
Sounds reasonable to me. Can we make this in a follow-up PR to leave this one focused only on wordings?
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Refer to #4724 (review).
@hzy46
Also, IMHO these two messages look contradictory:
LightGBM/src/io/dataset_loader.cpp
Line 838 in 5fbfa00
LightGBM/src/io/dataset_loader.cpp
Line 842 in 5fbfa00