-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Release 3.3.2 #4930
Conversation
* [docs] [R-package] update cran-comments for v3.3.1 release * Update R-package/cran-comments.md Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * update cran-comments.md now that v3.3.1 is accepted Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
/gha run r-configure |
* pin Dask version at CI * Update .vsts-ci.yml * Update .vsts-ci.yml * workaround for Python 3.6 * Update test.sh
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Ok with me that we don't have the valgrind
and solaris
checks on this PR, since they ran successfully on #4923. I pull this branch today just to double-check, and can confirm (from running git log -n 10
) that this only contains the new patch applied on top of v3.3.1.
One thing I'm unsure about is the release tag. Will we have to permanently keep this release_332
branch in the repo from this point forward? Since the tagged commit (dce7e58) will never be on master
.
If so I think that's fine, but we should add a branch protection on release_332
to prevent deleting it or pushing changes to it without a pull request (GitHub docs). I don't have sufficient permissions to do that on this repo, so it will have to be you (if you have the permissions) or @shiyu1994.
Once @shiyu1994 approves as well, I can handle uploading this release to CRAN. |
I'll check this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @StrikerRUS @jameslamb Thanks you!
OK, thanks for the feedback, guys! New GitHub release is out now and available for public access. |
Excellent! I'll submit to CRAN shortly and let you both know here when I do. I think we can close this pull request. |
Yeah, thanks! Everything is done according to the release checklist, except CRAN upload. Homebrew formula is under review right now: Homebrew/homebrew-core#92706.
I believe we should remind them to remove auto-patching in comments during upload. |
Good point! I'll do that. |
I've checked this and it seems we can remove underlying branch. I created test branch with test commit. Then I pushed test tag referring test commit. After that I removed entire test branch. And here's what I've got: |
I'm nervous about this. I've seen that when you delete a branch in the UI, there is a period of time where GitHub keeps it around and you can click "restore branch" to bring it back. Then, after some time (I do not know how long, but on the order of hours or days, not weeks or months), that's no longer possible. I wonder if there is the same "keep around for a short time and then permanently delete" behavior with commits not attached to a branch. I have two requests:
|
OK, I'll do this. But please note a yellow note of the screenshot above that indicates that the branch was removed. |
Also, our scenario is described here:
|
One thing that doesn't work with such type of releases is release auto-changelog. We are lacking all items since |
I just uploaded v3.3.2 to CRAN. @shiyu1994 you should receive an email from CRAN asking you to approve this submission. I included the following note with this submission (will add this to
|
@jameslamb Upload is now confirmed. Thank you! |
I strongly believe you are right:
We again need to ask CRAN team somehow to stop patching lightgbm... |
I believe we can remove |
Ok thanks for waiting and checking @StrikerRUS . Let's delete it. @shiyu1994 can you reply to CRAN and ask them to please stop applying that patch? |
Sure. Done with that. |
Have they answered anything? On CRAN version is still |
They've replied that the automatic patch is removed and checks are retriggered. I just saw the status right now too. I'll send another email to ensure that lightgbm 3.3.2 is being checked. |
OK, all tests have passed! 🎉 Not sure about additional tests though. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This is unusual release because it doesn't include all changes made since
v3.3.1
release inmaster
, but only contains urgent maintenance change to make LightGBM compatible with R 4.2. Refer to #4923 for more details.Tags and artifacts are made directly from
release_332
branch instead ofmaster
as usual, and this PR shouldn't be ever merged.Release checklist:
configure
file of R-package:/gha run r-configure
.development.mode
fromunreleased
torelease
in pkgdown config file.[ ] Run R valgrind checks after all PRs are merged:(cannot be run due to conflicts with/gha run r-valgrind
.master
)[ ] Run R Solaris checks after all PRs are merged:(cannot be run due to conflicts with/gha run r-solaris
.master
)v*
tag to triggerGitHubRelease
action at Azure Pipelines.Draft
to normal one.stable
tag at GitHub.old changelog might be needed in the future
Changes
💡 New Features
init()
andset_params()
methods @StrikerRUS ([python][sklearn] respect parameters for predictions ininit()
andset_params()
methods #4822)print()
andsummary()
methods for Booster @david-cortes ([R-package] Addprint()
andsummary()
methods for Booster #4686)n_estimators_
andn_iter_
post-fit attributes @StrikerRUS ([python][sklearn] addn_estimators_
andn_iter_
post-fit attributes #4753)🔨 Breaking
early_stopping_rounds
argument oftrain()
andcv()
functions @StrikerRUS ([python] removeearly_stopping_rounds
argument oftrain()
andcv()
functions #4908)evals_result
argument oftrain()
function @StrikerRUS ([python] removeevals_result
argument oftrain()
function #4882)None
forevals_result_
@StrikerRUS ([python][sklearn] do not replace empty dict withNone
forevals_result_
#4884)verbose_eval
argument oftrain()
andcv()
functions @StrikerRUS ([python] removeverbose_eval
argument oftrain()
andcv()
functions #4878)verbose
argument ofmodel_from_string()
method of Booster class @StrikerRUS ([python] removeverbose
argument ofmodel_from_string()
method of Booster class #4877)early_stopping_rounds
argument offit()
method @StrikerRUS ([python][sklearn] Removeearly_stopping_rounds
argument offit()
method #4846)slice()
@jameslamb ([R-package] remove support for '...' inslice()
#4872)lgb.Dataset()
@jameslamb ([R-package] remove support for '...' inlgb.Dataset()
#4874)dim.lgb.Dataset()
@jameslamb ([R-package] remove support for '...' indim.lgb.Dataset()
#4873)create_valid()
@jameslamb ([R-package] remove support for '...' increate_valid()
#4865)best_iteration
for sklearn and standard APIs @StrikerRUS ([python][sklearn] unify values ofbest_iteration
for sklearn and standard APIs #4845)verbose
argument fromfit()
method @StrikerRUS ([python][sklearn] removeverbose
argument fromfit()
method #4832)learning_rates
argument oftrain()
function @StrikerRUS ([python] removelearning_rates
argument oftrain()
function #4831)ylabel
argument ofplot_metric()
function @StrikerRUS ([python] remove "auto" value ofylabel
argument ofplot_metric()
function #4818)print_evaluation()
function @StrikerRUS ([python] Removeprint_evaluation()
function #4819)silent
argument @StrikerRUS ([python] Removesilent
argument #4800)🚀 Efficiency Improvement
🐛 Bug Fixes
lgb.cv
ignoresverbose
argument #4667) @jameslamb ([R-package] respect 'verbose' argument in lgb.cv() (fixes #4667) #4903)--no-build-vignettes
option forbuild-cran-package.sh
@jameslamb ([R-package] fix--no-build-vignettes
option forbuild-cran-package.sh
#4848)array-like
wording @StrikerRUS ([python][docs] fix type hints for custom functions and remove vaguearray-like
wording #4816)📖 Documentation
pred_early_stop
can be used only in normal and raw scores prediction @StrikerRUS ([docs] document thatpred_early_stop
can be used only in normal and raw scores prediction #4823)Returns
section to docstrings offit()
methods of Dask estimators #4402) @jameslamb ([docs] [dask] Add return information to Dask fit() docs (fixes #4402) #4716)nthreads
parameter @StrikerRUS ([docs] improve docs aboutnthreads
parameter #4756)🧰 Maintenance
testthat::expect_is()
@jameslamb ([R-package][tests] remove uses oftestthat::expect_is()
#4916)UnboundLocalError
in early stopping callback for Python 2 @StrikerRUS ([python] remove workaround forUnboundLocalError
in early stopping callback for Python 2 #4855)_compare_params_for_warning()
and make it reusable @StrikerRUS ([python] add type hints to_compare_params_for_warning()
and make it reusable #4824)CMAKE_CUDA_FLAGS
variable inCMakeLists.txt
@StrikerRUS ([ci] simplify processing ofCMAKE_CUDA_FLAGS
variable inCMakeLists.txt
#4799)linelength
errors @StrikerRUS ([ci] fix CMakeLintlinelength
errors #4796)endif()
andendfunction()
without expression inside inCMakeLists.txt
@StrikerRUS ([ci] use pureendif()
andendfunction()
without expression inside inCMakeLists.txt
#4798)filename
that is no longer true with new version of graphviz @StrikerRUS ([ci][tests][python] remove assertion forfilename
that is no longer true with new version of graphviz #4778)freetype
version @StrikerRUS ([ci] Revert temp workaround forfreetype
version #4776)cv()
function @StrikerRUS ([python] improve warning message about aliases incv()
function #4766)datatable
to the mocked modules during docs building process and sort them alphabetically @StrikerRUS ([docs][python] adddatatable
to the mocked modules during docs building process and sort them alphabetically #4750)