-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] fix getting status of optional workflows in PRs with a lot of comments #4806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha WOW, I never imagined we'd have a PR with so many comments that it would require pagination over GitHub API results 😂
thanks for investigating this
Thank you for this. Sorry about the long PR which causes inconvenience. |
Don't worry at all! Sorry, I was not complaining. I appreciate you patiently keeping it open all this time until we were ready to start on 4.0. I've also been the author of PRs with a lot of comments 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me, thanks!
That was totally my fault in poor design of comments retrieving routine. Of course, it should has worked for any size PRs from the beginning. I'm sorry about that! |
Many thanks to you for supporting the ci tests. You've done very well! |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Refer to https://docs.github.com/en/rest/reference/issues#list-issue-comments.
In #3234 (comment) script cannot update status for Solaris CI build because it doesn't receive the latest comments in that PR.