Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] add type hints to _compare_params_for_warning() and make it reusable #4824

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Pass keys that should be ignored during comparing to make _compare_params_for_warning() function reusable.

Function was introduced in #4768.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally support this re-factoring, I think this is a bit easier to follow. Thanks!

@StrikerRUS StrikerRUS merged commit a1fdeb1 into master Nov 23, 2021
@StrikerRUS StrikerRUS deleted the params_warning branch November 23, 2021 12:52
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants