Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] remove support for '...' in lgb.train() #4863

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

jameslamb
Copy link
Collaborator

Contributes to #4226.

This PR removes support for passing anything through ... in lgb.train().

Notes for Reviewers

v3.3.0 and v3.3.1 contain a deprecation warning about this change.

@@ -108,14 +108,6 @@ NULL
#' say "the first and tenth columns").}
#' \item{\code{reset_data}: Boolean, setting it to TRUE (not the default value) will transform the booster model
#' into a predictor model which frees up memory and the original datasets}
#' \item{\code{boosting}: Boosting type. \code{"gbdt"}, \code{"rf"}, \code{"dart"} or \code{"goss"}.}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remove ... in lightgbm() because it can be used to pass through keyword arguments to lgb.train().

train_args <- list(
"params" = params
, "data" = dtrain
, "nrounds" = nrounds
, "verbose" = verbose
, "eval_freq" = eval_freq
, "early_stopping_rounds" = early_stopping_rounds
, "init_model" = init_model
, "callbacks" = callbacks
, "serializable" = serializable
)
train_args <- append(train_args, list(...))

So for this PR, I just removed from the docs any mentions of LightGBM parameters from https://lightgbm.readthedocs.io/en/latest/Parameters.html (since those will now result in "unrecognized argument" errors).

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this cleanup!
Just two typos.

R-package/tests/testthat/test_lgb.Booster.R Outdated Show resolved Hide resolved
R-package/vignettes/basic_walkthrough.Rmd Outdated Show resolved Hide resolved
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
@jameslamb jameslamb requested a review from StrikerRUS December 7, 2021 22:16
@jameslamb jameslamb merged commit 00f87c5 into master Dec 7, 2021
@jameslamb jameslamb deleted the lgb-train-no-dots branch December 7, 2021 22:52
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants