Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] fix CVBooster reset_parameter() method (fixes #4900) #4901

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

jameslamb
Copy link
Collaborator

Fixes #4900.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one small comment in test.

Comment on lines 393 to 397
, nrounds = 2L
, nfold = 2L
)
expect_is(cv_bst, "lgb.CVBooster")
expect_length(cv_bst$boosters, 2L)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use different values for nrounds and nfold arguments to make it clearer what value is asserted in expect_length(cv_bst$booster, ....

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah, good idea!

updated in 52bce82

@jameslamb jameslamb requested a review from StrikerRUS December 22, 2021 02:07
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jameslamb jameslamb merged commit 34b7484 into master Dec 22, 2021
@jameslamb jameslamb deleted the fix/cv-booster-reset-parameter branch December 22, 2021 15:47
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R-package] CVBooster$reset_parameter() is broken
2 participants