[DO NOT MERGE] Release v3.3.4 #5619
Conversation
jameslamb
requested review from
StrikerRUS,
guolinke,
chivee,
btrotta,
shiyu1994,
hzy46 and
tongwu-sh
as code owners
jameslamb
removed request for
chivee,
tongwu-sh,
hzy46,
shiyu1994,
guolinke,
StrikerRUS and
btrotta
|
/gha run r-configure |
| @@ -7,6 +7,7 @@ if [[ $OS_NAME == "macos" ]]; then | |||
| sudo xcode-select -s /Applications/Xcode_10.3.app/Contents/Developer || exit -1 | |||
| fi | |||
| else # gcc | |||
| sudo xcode-select -s /Applications/Xcode_14.1.app/Contents/Developer || exit -1 | |||
There was a problem hiding this comment.
had to pull in this change from #5580 for GitHub Actions and Azure CI jobs on macOS-latest to work
|
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
|
Since all of the R tests are passing on this branch, and since we have less than 2 days left to get a new CRAN submission up, I've submitted the R package built from this branch to CRAN. @shiyu1994 please check your email and click the confirmation link there.
I'll continue trying to get this branch building successfully so we can do a full release of the project (e.g. to PyPI, NuGet, GitHub releases page). But the CRAN update is the main reason for this, and the most urgent thing to get done. And also I'm traveling tomorrow night 😅 |
|
ok I think this is ready for review! We can ignore the linting and @shiyu1994 @guolinke @jmoralez can you please review? If you all approve, I'll cut a release, push wheels to PyPI, etc. and then we can fully focus on v4.0.0 |
|
@jameslamb Hi James, thanks for working on this. I got another email from CRAN on Jan 1st. We need to fix a compilation warning before Jan 15th (see #5661). Do you think we should fix that along with this PR. |
@shiyu1994 no, I think it should be a new PR and a Could you approve this PR if you're comfortable with releasing this branch? We still haven't pushed a v3.3.4 to PyPI, GitHub Releases, etc.... I can do that if you approve, then start on a v3.3.5. |
|
@jameslamb Thanks for your help! Feel free to contact me at anytime if there's something I can do. |
|
Thank you! I'm going to do the following then:
|
|
Alright, continuing on this release! I'll continue editing this comment as things progress, so we have a single comment to link to with more details on what to do in the upcoming v3.3.5 release.
git tag v3.3.4
git push upstream v3.3.4(I use
git fetch upstream --tags
git tag -d stable
git push upstream :refs/tags/stable
git tag stable v3.3.4
git push upstream stablehttps://github.com/microsoft/LightGBM/tags
see https://pypi.org/project/lightgbm/
downloaded the files from the release, then uploaded them like this: twine upload -u ${PYPI_USER} dist/*
|
|
release |
|
This work is now complete. Thanks for the help everyone! |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Similar to #5525, this is an unusual release. It is
v3.3.4, but doesn't include all of the changes made sincev3.3.3.Instead, this PR just contains the changes on top of
v3.3.4needed to prevent the R package from being archived by CRAN.Fixes #5618.
THIS PR SHOULD NEVER BE MERGED
Setup
I created a new branch,
release/v3.3.3, which contains only:v3.3.3master(f0cfbff)how I did that (click me)
Tags and artifacts should be made directly from this
release_v3.3.4branch instead ofmaster.Release checklist:
Copied from #5525.
configurefile of R-package:/gha run r-configure.development.modefromunreleasedtoreleasein pkgdown config file.v*tag to triggerGitHubReleaseaction at Azure Pipelines.Draftto normal one.stabletag at GitHub.What about the changelog?
As described in #4930 (comment), doing this interferes with the automatic changelog generation we get from the release-draft bot.
So just like @StrikerRUS did in #4930 and I did in #5525, I've included the current draft changelog here, as well as the one saved in the comments on #4930.
changelog from v3.3.1 to when v3.3.2 was created (click me)
NOTE: I wrapped this in a markdown text block so GitHub stops re-evaluating the links.
changelog from when v3.3.2 was created to date of v3.3.3 (click me)
NOTE: I wrapped this in a markdown text block so GitHub stops re-evaluating the links.
changelog from when v3.3.3 was created to today (click me)
NOTE: I wrapped this in a markdown text block so GitHub stops re-evaluating the links.