Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround clang __is_base_of bug in <type_traits> #167

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

CaseyCarter
Copy link
Member

Description

Clang's __is_base_of intrinsic incorrectly handles some corner cases involving incomplete union types before LLVM 9. Workaround by guarding with __is_class.

(This is a replay of Microsoft-internal PR 206866.)

Checklist

If you're unsure about a box, leave it unchecked. A maintainer will help you.

If a box isn't applicable, add an explanation in bold.
For example: (N/A: this is a bugfix, not a feature)

  • I understand README.md. I also understand that acceptance of
    community PRs will be delayed until the test and CI systems are online.
  • If this is a feature addition, that feature has been voted into the
    C++ Working Draft.
  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 .
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before CI is online, leave this unchecked for
    initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository and
    the C++ Working Draft as a reference (and any other cited standards).
    If they were derived from a project that's already listed in NOTICE.txt,
    that's fine, but please mention it. If they were derived from any other
    project (including Boost and libc++, which are not yet listed in
    NOTICE.txt), you must mention it here, so we can determine whether the
    license is compatible and what else needs to be done.

Clang's `__is_base_of` intrinsic incorrectly handles some corner cases involving incomplete union types before LLVM 9. Workaround by guarding with `__is_class`.
@CaseyCarter CaseyCarter requested a review from a team as a code owner October 10, 2019 01:08
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why I believe that direct use of type traits intrinsics should be avoided throughout the STL and we should always use the Standard wrappers.

@CaseyCarter
Copy link
Member Author

This is why I believe that direct use of type traits intrinsics should be avoided throughout the STL and we should always use the Standard wrappers.

I don't believe that the type trait intrinsics are inherently more buggy than any other compiler-provided feature that we rely upon. It's also fairly simple to grep for __is_foo(X, Y) and non-mechanically replace with is_foo_v<X, Y> if necessary. "Every compile should be a bit slower to save us a few minutes every time we need to workaround an intrinsic bug." is not a compelling argument to me.

@CaseyCarter CaseyCarter merged commit f565496 into microsoft:master Oct 10, 2019
@CaseyCarter CaseyCarter deleted the replay branch October 10, 2019 01:21
fengjixuchui added a commit to fengjixuchui/STL that referenced this pull request Oct 10, 2019
Workaround clang __is_base_of bug in <type_traits> (microsoft#167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants