Increase size of span for unused declaration #22388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
mhegazy
approved these changes
Mar 7, 2018
sheetalkamat
approved these changes
Mar 7, 2018
amcasey
approved these changes
Mar 7, 2018
mihailik
reviewed
Mar 8, 2018
| @@ -1,10 +1,10 @@ | |||
| tests/cases/compiler/unusedClassesinModule1.ts(2,11): error TS6133: 'Calculator' is declared but its value is never read. | |||
| tests/cases/compiler/unusedClassesinModule1.ts(2,5): error TS6133: 'Calculator' is declared but its value is never read. | |||
|
|
|||
|
|
|||
| ==== tests/cases/compiler/unusedClassesinModule1.ts (1 errors) ==== | |||
| module A { | |||
| class Calculator { | |||
There was a problem hiding this comment.
What's going to happen for generic class?
Calculator<T>
Calculator<T where T extends K>
| tests/cases/compiler/noUnusedLocals_selfReference.ts(12,1): error TS6133: 'E' is declared but its value is never read. | ||
| tests/cases/compiler/noUnusedLocals_selfReference.ts(13,1): error TS6133: 'I' is declared but its value is never read. | ||
| tests/cases/compiler/noUnusedLocals_selfReference.ts(14,1): error TS6133: 'T' is declared but its value is never read. | ||
| tests/cases/compiler/noUnusedLocals_selfReference.ts(15,1): error TS6133: 'N' is declared but its value is never read. | ||
| tests/cases/compiler/noUnusedLocals_selfReference.ts(22,19): error TS6133: 'm' is declared but its value is never read. | ||
|
|
||
|
|
||
| ==== tests/cases/compiler/noUnusedLocals_selfReference.ts (8 errors) ==== | ||
| export {}; // Make this a module scope, so these are local variables. | ||
|
|
||
| function f() { |
There was a problem hiding this comment.
What about generic functions?
function f<T>() {
function f<T where T extends K> () {
Also what about async functions?
async function f() {
Also what about class methods?
private f() {
| tests/cases/compiler/noUnusedLocals_selfReference_skipsBlockLocations.ts(12,22): error TS6133: 'h' is declared but its value is never read. | ||
| tests/cases/compiler/noUnusedLocals_selfReference_skipsBlockLocations.ts(2,5): error TS6133: 'f' is declared but its value is never read. | ||
| tests/cases/compiler/noUnusedLocals_selfReference_skipsBlockLocations.ts(8,13): error TS6133: 'g' is declared but its value is never read. | ||
| tests/cases/compiler/noUnusedLocals_selfReference_skipsBlockLocations.ts(12,13): error TS6133: 'h' is declared but its value is never read. | ||
|
|
||
|
|
||
| ==== tests/cases/compiler/noUnusedLocals_selfReference_skipsBlockLocations.ts (3 errors) ==== | ||
| namespace n { | ||
| function f() { |
There was a problem hiding this comment.
Comments or extensive whitespace/newlines between function and f — will those be included in the span, or break off the function part out of the span?
| @@ -1,10 +1,10 @@ | |||
| tests/cases/compiler/unusedNamespaceInNamespace.ts(2,15): error TS6133: 'B' is declared but its value is never read. | |||
| tests/cases/compiler/unusedNamespaceInNamespace.ts(2,5): error TS6133: 'B' is declared but its value is never read. | |||
|
|
|||
|
|
|||
| ==== tests/cases/compiler/unusedNamespaceInNamespace.ts (1 errors) ==== | |||
| namespace A { | |||
| namespace B { } | |||
There was a problem hiding this comment.
Worth adding enum, var/let/const tests too.
Anything else?
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Jun 1, 2018
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Jun 1, 2018
ghost
pushed a commit
that referenced
this pull request
Jun 1, 2018
ghost
pushed a commit
that referenced
this pull request
Jun 1, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #22361 (comment)