Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(40632): Don't emit abstract members #40699

Merged
merged 1 commit into from
Nov 5, 2020
Merged

fix(40632): Don't emit abstract members #40699

merged 1 commit into from
Nov 5, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #40632

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Sep 22, 2020
@RyanCavanaugh
Copy link
Member

We need to push this to 4.2 since it's a fairly observable runtime breaking change

@RyanCavanaugh RyanCavanaugh added this to the TypeScript 4.2.0 milestone Sep 22, 2020
@sandersn sandersn mentioned this pull request Sep 25, 2020
Open
5 tasks
@sandersn sandersn self-assigned this Oct 5, 2020
@DanielRosenwasser DanielRosenwasser mentioned this pull request Nov 4, 2020
Closed
@sandersn sandersn merged commit 45b698b into microsoft:master Nov 5, 2020
alangpierce added a commit to alangpierce/sucrase that referenced this pull request Aug 2, 2022
@alangpierce
Remove abstract fields when disableESTransforms is enabled
07196e5 
Fixes #731

`disableESTransforms` is intended to match the more spec-compliant mode
`useDefineForClassFields` provided by TypeScript, but it looks like in TS 4.2
they updated the behavior so that `abstract` fields are removed in addition to
`declare` fields:
microsoft/TypeScript#40699

In Sucrase, we can implement the same behavior by simply testing for `abstract`
as well in the place where we test for `declare`.
@alangpierce alangpierce mentioned this pull request Aug 2, 2022
Merged
alangpierce added a commit to alangpierce/sucrase that referenced this pull request Aug 2, 2022
@alangpierce
Remove abstract fields when disableESTransforms is enabled (#732)
44eb2ae 
Fixes #731

`disableESTransforms` is intended to match the more spec-compliant mode
`useDefineForClassFields` provided by TypeScript, but it looks like in TS 4.2
they updated the behavior so that `abstract` fields are removed in addition to
`declare` fields:
microsoft/TypeScript#40699

In Sucrase, we can implement the same behavior by simply testing for `abstract`
as well in the place where we test for `declare`.
1Lighty pushed a commit to Astra-mod/sucrase that referenced this pull request Aug 14, 2022
@alangpierce @1Lighty
Remove abstract fields when disableESTransforms is enabled (alangpier…
5ff02f1 
…ce#732)

Fixes alangpierce#731

`disableESTransforms` is intended to match the more spec-compliant mode
`useDefineForClassFields` provided by TypeScript, but it looks like in TS 4.2
they updated the behavior so that `abstract` fields are removed in addition to
`declare` fields:
microsoft/TypeScript#40699

In Sucrase, we can implement the same behavior by simply testing for `abstract`
as well in the place where we test for `declare`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@nitish-awasthi nitish-awasthi nitish-awasthi approved these changes

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees

@sandersn sandersn

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
TypeScript 4.2.0
Development

Successfully merging this pull request may close these issues.

Don't emit abstract members
5 participants
@a-tarasyuk @RyanCavanaugh @sandersn @nitish-awasthi @typescript-bot