Remove abstract fields when disableESTransforms is enabled #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #731 `disableESTransforms` is intended to match the more spec-compliant mode `useDefineForClassFields` provided by TypeScript, but it looks like in TS 4.2 they updated the behavior so that `abstract` fields are removed in addition to `declare` fields: microsoft/TypeScript#40699 In Sucrase, we can implement the same behavior by simply testing for `abstract` as well in the place where we test for `declare`.
Codecov Report
@@ Coverage Diff @@
## main #732 +/- ##
=======================================
Coverage 87.17% 87.17%
=======================================
Files 54 54
Lines 5722 5722
Branches 1349 1349
=======================================
Hits 4988 4988
Misses 466 466
Partials 268 268
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Benchmark resultsBefore this PR: 410.2 thousand lines per second Measured change: 1.63% faster (0.21% faster to 6.36% faster) |
alangpierce
deleted the
remove-abstract-fields-with-disable-es-transforms
branch
1Lighty
pushed a commit
to Astra-mod/sucrase
that referenced
this pull request
Aug 14, 2022
…ce#732) Fixes alangpierce#731 `disableESTransforms` is intended to match the more spec-compliant mode `useDefineForClassFields` provided by TypeScript, but it looks like in TS 4.2 they updated the behavior so that `abstract` fields are removed in addition to `declare` fields: microsoft/TypeScript#40699 In Sucrase, we can implement the same behavior by simply testing for `abstract` as well in the place where we test for `declare`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #731
disableESTransformsis intended to match the more spec-compliant modeuseDefineForClassFieldsprovided by TypeScript, but it looks like in TS 4.2they updated the behavior so that
abstractfields are removed in addition todeclarefields:microsoft/TypeScript#40699
In Sucrase, we can implement the same behavior by simply testing for
abstractas well in the place where we test for
declare.