Remove abstract fields when disableESTransforms is enabled #732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #731
disableESTransforms
is intended to match the more spec-compliant modeuseDefineForClassFields
provided by TypeScript, but it looks like in TS 4.2they updated the behavior so that
abstract
fields are removed in addition todeclare
fields:microsoft/TypeScript#40699
In Sucrase, we can implement the same behavior by simply testing for
abstract
as well in the place where we test for
declare
.