fix(49223): checker.getTypeAtLocation for ExpressionWithTypeArguments returns an error any type

[a-tarasyuk]

Fixes #49223

[bradennapier]

That was quick! Thanks!

[DanielRosenwasser]

@typescript-bot cherry-pick this to release-4.7

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.7 on this PR at 1394d80. You can monitor the build here.

[typescript-bot]

Hey @DanielRosenwasser, I've opened #49346 for you.

[DanielRosenwasser]

Ugh, sorry. Would you be able to accept baselines?

[DanielRosenwasser]

Doing this pretty much wrecks every .types baseline so that something like

class ContextMenu extends EventManager {
  // ...
}

has the following diff

  >ContextMenu : ContextMenu
- >EventManager : EventManager
+ >EventManager : typeof EventManager
+ >EventManager : typeof EventManager

[DanielRosenwasser]

It also breaks how find-all-refs seems to work.

  // === /tests/cases/fourslash/findAllRefsForStaticInstanceMethodInheritance.ts ===
  // class X{
  // 	/*FIND ALL REFS*/[|foo|](): void{}
  // }
  // 
  // class Y extends X{
  // 	static foo(): void{}
  // }
  // 
  // class Z extends Y{
  // 	static foo(): void{}
- // 	[|foo|](): void{}
+ // 	foo(): void{}
  // }
  // 
  // const x = new X();
  // const y = new Y();
  // const z = new Z();
  // x.[|foo|]();
  // y.[|foo|]();
- // z.[|foo|]();
+ // z.foo();
  // Y.foo();
  // Z.foo();

@ahejlsberg @RyanCavanaugh @andrewbranch to be honest, I am considering putting this into a 4.7.4 change unless others can help guide this PR today.

[DanielRosenwasser]

Unless we just revert my change at 1394d80 and go with @a-tarasyuk's original change.

[ahejlsberg]

I would go with return !isHeritageClause(node.parent); instead of the original change (since the other part of the expression is redundant).

[DanielRosenwasser]

Everything seems to pass with just that.

[DanielRosenwasser]

@typescript-bot cherry-pick this to release-4.7

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.7 on this PR at 3ed5d0a. You can monitor the build here.

[typescript-bot]

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.7 manually.