Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #49284 to release-4.7 #49369

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

DanielRosenwasser
Copy link
Member

Cherry pick #49284 to release-4.7

… returns an error any type (#49284)

* fix(49223): handle ExpressionWithTypeArguments nodes in isExpressionNode

* Update src/compiler/utilities.ts

* Just use `!isHeritageClause(node.parent)`.

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 3, 2022
@DanielRosenwasser
Copy link
Member Author

I guess I'm going to also use this PR as a check to get a sense of regressions. Not sure if it will work off of main.

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 3, 2022

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 1a3c5eb. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 3, 2022

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 1a3c5eb. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 3, 2022

Heya @DanielRosenwasser, I've started to run the diff-based community code test suite on this PR at 1a3c5eb. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 3, 2022

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at 1a3c5eb. You can monitor the build here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants