feat(tab-stops-details-view): Remove instances on undo and update (#4903

)
microsoft · Nov 19, 2021 · 8c99d9c · 8c99d9c
1 parent df4c135
commit 8c99d9c
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 1 deletion.
diff --git a/src/background/stores/visualization-scan-result-store.ts b/src/background/stores/visualization-scan-result-store.ts
@@ -145,6 +145,9 @@ export class VisualizationScanResultStore extends BaseStoreImpl<VisualizationSca
     ): void => {
         const { requirementId, status } = payload;
         this.state.tabStops.requirements[requirementId].status = status;
+        if (status === 'pass') {
+            this.state.tabStops.requirements[requirementId].instances = [];
+        }
         this.emitChanged();
     };
 
@@ -153,6 +156,7 @@ export class VisualizationScanResultStore extends BaseStoreImpl<VisualizationSca
     ): void => {
         const { requirementId } = payload;
         this.state.tabStops.requirements[requirementId].status = TabStopRequirementStatuses.unknown;
+        this.state.tabStops.requirements[requirementId].instances = [];
         this.emitChanged();
     };
 

diff --git a/src/tests/unit/tests/background/stores/visualization-scan-result-store.test.ts b/src/tests/unit/tests/background/stores/visualization-scan-result-store.test.ts
@@ -4,6 +4,7 @@ import {
     AddTabbedElementPayload,
     AddTabStopInstancePayload,
     RemoveTabStopInstancePayload,
+    ResetTabStopRequirementStatusPayload,
     UpdateTabStopInstancePayload,
     UpdateTabStopRequirementStatusPayload,
 } from 'background/actions/action-payloads';
@@ -406,8 +407,12 @@ describe('VisualizationScanResultStoreTest', () => {
         );
     });
 
-    test('onUpdateTabStopRequirementStatus', () => {
+    test('onUpdateTabStopRequirementStatus updates status and removes instances', () => {
         const initialState = new VisualizationScanResultStoreDataBuilder().build();
+        initialState.tabStops.requirements['keyboard-navigation'].status = 'fail';
+        initialState.tabStops.requirements['keyboard-navigation'].instances = [
+            { description: 'test1', id: 'abc' },
+        ];
 
         const payload: UpdateTabStopRequirementStatusPayload = {
             requirementId: 'keyboard-navigation',
@@ -431,6 +436,34 @@ describe('VisualizationScanResultStoreTest', () => {
             .testListenerToBeCalledOnce(initialState, expectedState);
     });
 
+    test('onResetTabStopRequirementStatus resets status and removes instances', () => {
+        const initialState = new VisualizationScanResultStoreDataBuilder().build();
+        initialState.tabStops.requirements['keyboard-navigation'].status = 'fail';
+        initialState.tabStops.requirements['keyboard-navigation'].instances = [
+            { description: 'test1', id: 'abc' },
+        ];
+
+        const payload: ResetTabStopRequirementStatusPayload = {
+            requirementId: 'keyboard-navigation',
+        };
+
+        const requirement: TabStopRequirementState = {
+            'keyboard-navigation': {
+                status: 'unknown',
+                instances: [],
+                isExpanded: false,
+            },
+        };
+
+        const expectedState = new VisualizationScanResultStoreDataBuilder()
+            .withTabStopRequirement(requirement)
+            .build();
+
+        createStoreTesterForTabStopRequirementActions('resetTabStopRequirementStatus')
+            .withActionParam(payload)
+            .testListenerToBeCalledOnce(initialState, expectedState);
+    });
+
     test('onAddTabStopInstance', () => {
         const initialState = new VisualizationScanResultStoreDataBuilder().build();