Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tab-stops-details-view): Remove instances on undo and update #4903

Merged
merged 3 commits into from
Nov 19, 2021

Conversation

brocktaylor7
Copy link
Contributor

@brocktaylor7 brocktaylor7 commented Nov 18, 2021

Details

This deletes existing failed instances for a requirement in two scenarios:

  1. If a previously failed requirement is changed to "Pass"
  2. If the "Undo" button is clicked
Motivation

Feature work

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@brocktaylor7 brocktaylor7 requested a review from a team as a code owner November 18, 2021 23:44
@brocktaylor7 brocktaylor7 changed the title feat(tab-stops-details-view): Remove instances on undo, pass, and start over feat(tab-stops-details-view): Remove instances on undo and update Nov 19, 2021
@brocktaylor7 brocktaylor7 merged commit 8c99d9c into microsoft:main Nov 19, 2021
@brocktaylor7 brocktaylor7 deleted the remove-instances-on-reset branch November 19, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants