Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor text changes in Contrast > UI components and Contrast > State changes #3806

Closed
LiLoDavis opened this issue Jan 7, 2021 · 7 comments
Closed

Minor text changes in Contrast > UI components and Contrast > State changes #3806

LiLoDavis opened this issue Jan 7, 2021 · 7 comments
Labels
bug Something isn't working good first issue Good for newcomers status: resolved This issue has been merged into main and deployed to canary.

Comments

@LiLoDavis
Copy link

Describe the problem

In How to test, both requirements mention the same exceptions:

Exception: A lower contrast ratio is allowed if either of the following is true:
a. The component is inactive/disabled.
b. The component's appearance is determined solely by the browser.

However, this text could be interpreted as meaning that there's another, lower threshold for these components, when in fact there isn't.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Contrast > UI components or Contrast > State changes.
  2. Look at the content immediately after step 2b.

Proposed text

Exception: No minimum contrast ratio is required if either of the following is true:
a. The component is inactive/disabled.
b. The component's appearance is determined solely by the browser.

Change the text

Are you willing to submit a PR?

No.
@LiLoDavis LiLoDavis added the bug Something isn't working label Jan 7, 2021
@ghost ghost added the status: new This issue is new and requires triage by DRI. label Jan 7, 2021
@ghost ghost assigned DaveTryon Jan 7, 2021
@DaveTryon DaveTryon added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels Jan 7, 2021
@ghost ghost assigned ferBonnin Jan 7, 2021
@ghost
Copy link

ghost commented Jan 7, 2021

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@DaveTryon DaveTryon removed their assignment Jan 7, 2021
@ferBonnin ferBonnin added status: ready for work This issue is ready to be worked on. good first issue Good for newcomers and removed status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. labels Jan 11, 2021
@ghost ghost added the help wanted Extra attention is needed label Jan 11, 2021
@cutePanda123 cutePanda123 mentioned this issue Jan 31, 2021
Merged
7 tasks
dbjorge pushed a commit that referenced this issue Feb 1, 2021
@cutePanda123
fix: update Contrast how to test exception text (#3852)
f8d20d8 
#### Description of changes
update Contrast how to test exception text to address issue #3806

#### Pull request checklist
- [x] Addresses an existing issue: #3806 
- [x] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`.
- [x] (UI changes only) Added screenshots/GIFs to description above
- [x] (UI changes only) Verified usability with NVDA/JAWS


screenshot:
![image](https://user-images.githubusercontent.com/26092755/106390657-49daf100-639e-11eb-868f-9ff2155ba9c7.png)
@dbjorge dbjorge added the status: resolved This issue has been merged into main and deployed to canary. label Feb 1, 2021
@ghost ghost removed the status: ready for work This issue is ready to be worked on. label Feb 1, 2021
@dbjorge
Copy link
Contributor

dbjorge commented Feb 1, 2021

Resolved by @cutePanda123 in #3852 (thanks for the contribution!)

@ferBonnin
Copy link
Contributor

@LiLoDavis could you please take a look and close? :)

@LiLoDavis
Copy link
Author

@ferBonnin Fixed in Contrast > UI Components, but not yet in > State changes.

@ferBonnin ferBonnin added the status: ready for work This issue is ready to be worked on. label Feb 1, 2021
@ghost ghost removed the status: resolved This issue has been merged into main and deployed to canary. label Feb 1, 2021
@ferBonnin
Copy link
Contributor

thanks @LiLoDavis! marking this as ready for work to address in State changes

@cutePanda123 cutePanda123 mentioned this issue Feb 1, 2021
Merged
7 tasks
peterdur pushed a commit that referenced this issue Feb 3, 2021
@cutePanda123
fix: update Contrast > State changes exception text (#3854)
032cbbc 
* update exception text in Contrast->State changes as suggested in #3806
@peterdur peterdur added the status: resolved This issue has been merged into main and deployed to canary. label Feb 3, 2021
@ghost ghost removed the status: ready for work This issue is ready to be worked on. label Feb 3, 2021
@peterdur
Copy link
Contributor

peterdur commented Feb 3, 2021

@LiLoDavis the State Changes fix should now be in Canary.

@LiLoDavis
Copy link
Author

Looks good

@DaveTryon DaveTryon removed the help wanted Extra attention is needed label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers status: resolved This issue has been merged into main and deployed to canary.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dbjorge @peterdur @karanbirsingh @ferBonnin @LiLoDavis @DaveTryon