Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Contrast > State changes exception text #3854

Merged
merged 3 commits into from
Feb 3, 2021

Conversation

cutePanda123
Copy link
Contributor

Description of changes

Update Contrast > State changes exception text to address issue #3806

Pull request checklist

  • Addresses an existing issue: Minor text changes in Contrast > UI components and Contrast > State changes #3806
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

screenshot:
image

@cutePanda123 cutePanda123 requested a review from a team as a code owner February 1, 2021 22:41
Copy link
Contributor

@peterdur peterdur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for taking care this second case. We didn't recognize you with your new username!

@peterdur peterdur merged commit 032cbbc into microsoft:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants