Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android-report): minor style fix + minor text change to footer text #2479

Merged
merged 2 commits into from
Apr 13, 2020
Merged

fix(android-report): minor style fix + minor text change to footer text #2479

merged 2 commits into from
Apr 13, 2020

Conversation

waabid
Copy link
Member

@waabid waabid commented Apr 10, 2020

Description of changes

Minor changes to:

  1. Make the report scrollable in android.
  2. Remove the Not Applicable rules component
  3. Modify the text in footer to use tool data scan engine name.

Screenshot:
image

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@waabid waabid requested a review from a team as a code owner April 10, 2020 23:05
pownkel
pownkel approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@pownkel pownkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waabid waabid merged commit c969bba into microsoft:master Apr 13, 2020
@waabid waabid deleted the minorReportImprovements branch January 27, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pownkel pownkel pownkel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waabid @pownkel