Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android-report): minor style fix + minor text change to footer text #2479

Merged
merged 2 commits into from
Apr 13, 2020
Merged

fix(android-report): minor style fix + minor text change to footer text #2479

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b19a9cc
fix(android-report): minor style fix + minor text change to footer text
waabid Apr 10, 2020
896be0d
removed lint issue
waabid Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/electron/views/report/unified-report-section-factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.
import { FailedInstancesSection } from 'common/components/cards/failed-instances-section';
import { NullComponent } from 'common/components/null-component';
import { UnifiedReportHead } from 'electron/views/report/unified-report-head';
import { BodySection } from 'reports/components/report-sections/body-section';
import { ContentContainer } from 'reports/components/report-sections/content-container';
Expand All @@ -26,7 +27,7 @@ export const UnifiedReportSectionFactory: ReportSectionFactory = {
ResultsContainer,
FailedInstancesSection,
PassedChecksSection,
NotApplicableChecksSection,
NotApplicableChecksSection: NullComponent,
FooterSection: ReportFooter,
FooterText: FooterTextForUnified,
};
1 change: 0 additions & 1 deletion src/electron/views/root-container/components/root-container.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ body {
margin: 0px;
height: 100%;
width: 100%;
overflow: hidden;
background-color: $neutral-0;
font-family: $fontFamily;
}
Expand Down
2 changes: 1 addition & 1 deletion src/reports/components/report-sections/footer-text-for-unified.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const FooterTextForUnified = NamedFC<FooterTextProps>(
return (
<>
This automated checks result was generated using{' '}
{`${toolData.applicationProperties.name} ${toolData.applicationProperties.version} (axe-core ${toolData.scanEngineProperties.version})`}
{`${toolData.applicationProperties.name} ${toolData.applicationProperties.version} (${toolData.scanEngineProperties.name} ${toolData.scanEngineProperties.version})`}
, a tool that helps debug and find accessibility issues earlier. Get more
information & download this tool at <ToolLink />.
</>
Expand Down
2 changes: 1 addition & 1 deletion ...ts/reports/components/report-sections/__snapshots__/footer-text-for-unified.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`FooterText renders 1`] = `
<React.Fragment>
This automated checks result was generated using

app-name app-version (axe-core engine-version)
app-name app-version (engine-name engine-version)
, a tool that helps debug and find accessibility issues earlier. Get more information & download this tool at
<ToolLink />
.
Expand Down