feat(Electron 8.x upgrade): Include electron version in build pipeline variable names #2538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This replaces the
ELECTRON_MIRROR_VAR
andELECTRON_CUSTOM_DIR_VAR
environment variables withELECTRON_701_MIRROR_VAR
andELECTRON_701_CUSTOM_DIR_VA
R, respectively. We're doing this to allow the build pipeline to support concurrent versions of Electron as we migrate to 8.x. A similar strategy will be applied to future version migrations.Note that
ELECTRON_MIRROR
andELECTRON_CUSTOM_DIR
are intentionally not changed, since these are the names of the data passed to the build tools.Unsigned build 2020.422.21 has been queued to validate that the correct version of Electron is getting picked up by the build pipeline.
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.