Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify electron mirror management #2749

Merged
merged 6 commits into from
Jun 1, 2020
Merged

Conversation

karanbirsingh
Copy link
Contributor

@karanbirsingh karanbirsingh commented May 22, 2020

Description of changes

Currently updating the electron version also requires some changes to build pipeline variables because the mirror URL needs to change (see #2538). This PR leverages improvements in @electron/get 1.12.2 to simplify this process so that only updating the asset number is required (moved to YAML) - the rest of the URL is computed from package.json and constant ADO variables.

Before this PR is merged, I need to add the constant ADO variables to the pipeline. So far they were added on a trial run you can see here.

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@karanbirsingh karanbirsingh requested a review from a team as a code owner May 22, 2020 18:11
yarn.lock Outdated Show resolved Hide resolved
@karanbirsingh karanbirsingh merged commit 995b423 into master Jun 1, 2020
@karanbirsingh karanbirsingh deleted the customize-url branch August 6, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants