Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert 63145e4 to fix stuck assessment > automated checks scanning #2698

Merged
merged 1 commit into from
May 15, 2020

Conversation

karanbirsingh
Copy link
Contributor

This reverts 63145e4, which introduced #2695. Details from Dan:

automated checks only indirectly renders the TestStepView via src\DetailsView\extensions\wait-for-all-requirements-to-complete.tsx; the test step view doesn't get mounted until after all the requirements complete, but the logic to start the visualizer was moved to the mount phase of the TestStepView"

This impacts the under-feature-flag reflow work, but is not intended to have other side effects

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@karanbirsingh karanbirsingh requested a review from a team as a code owner May 15, 2020 18:51
Copy link
Contributor

@dbjorge dbjorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity checked fastpass (automated checks and tab stops), all ad-hoc tools, assessment (automated checks, manual + assisted + manual-auto-pass) cases without the reflow flag active, didn't see any issues. Approved pending PR build results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants