Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nav-bar-content): remove update-handler from ReflowAssessmentView #2699

Merged
merged 1 commit into from
May 15, 2020

Conversation

pownkel
Copy link
Contributor

@pownkel pownkel commented May 15, 2020

Description of changes

Remove update-handler from ReflowAssessmentView (to be added back later in RequirementView). This will fix the errors on Getting Started that were reintroduced by the revert in #2698.

Pull request checklist

  • Addresses an existing issue: #1659964
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@pownkel pownkel requested a review from a team as a code owner May 15, 2020 19:45
@pownkel pownkel force-pushed the remove-update-handler branch from ffa56e2 to 83bbfbe Compare May 15, 2020 19:51
@waabid waabid merged commit a6384b9 into microsoft:master May 15, 2020
@pownkel pownkel deleted the remove-update-handler branch May 15, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants