Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android-setup): remove extra main elements in AndroidSetupSpinnerStep UIs #2906

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Jun 17, 2020

Description of changes

Several of the steps that are based on AndroidSetupSpinnerStep were wrapping it in a <main> element, but it already is based on AndroidSetupStepLayout which provides a <main> element. This removes the extra landmark.

No visual change.

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge requested a review from a team as a code owner June 17, 2020 20:35
@dbjorge dbjorge merged commit 9a27a18 into microsoft:master Jun 17, 2020
@dbjorge dbjorge deleted the remove-extra-main-wrappers branch June 17, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants