Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android-setup): remove extra main elements in AndroidSetupSpinnerStep UIs #2906

Merged
merged 1 commit into from
Jun 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ import { CommonAndroidSetupStepProps } from './android-setup-types';
export const DetectDevicesStep = NamedFC<CommonAndroidSetupStepProps>(
'DetectDevicesStep',
(props: CommonAndroidSetupStepProps) => {
return (
<main>
<AndroidSetupSpinnerStep deps={props.deps} spinnerLabel="Scanning for devices..." />
</main>
);
return <AndroidSetupSpinnerStep deps={props.deps} spinnerLabel="Scanning for devices..." />;
},
);
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ import { CommonAndroidSetupStepProps } from './android-setup-types';
export const DetectPermissionsStep = NamedFC<CommonAndroidSetupStepProps>(
'DetectPermissionsStep',
(props: CommonAndroidSetupStepProps) => {
return (
<main>
<AndroidSetupSpinnerStep deps={props.deps} spinnerLabel="Checking permissions..." />
</main>
);
return <AndroidSetupSpinnerStep deps={props.deps} spinnerLabel="Checking permissions..." />;
},
);
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,11 @@ export const DetectServiceStep = NamedFC<CommonAndroidSetupStepProps>(
'DetectServiceStep',
(props: CommonAndroidSetupStepProps) => {
return (
<main>
<AndroidSetupSpinnerStep
deps={props.deps}
spinnerLabel="Scanning for devices..."
disableCancel={true}
/>
</main>
<AndroidSetupSpinnerStep
deps={props.deps}
spinnerLabel="Scanning for devices..."
disableCancel={true}
/>
);
},
);
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,10 @@ export const InstallingServiceStep = NamedFC<CommonAndroidSetupStepProps>(
'InstallingServiceStep',
(props: CommonAndroidSetupStepProps) => {
return (
<main>
<AndroidSetupSpinnerStep
deps={props.deps}
spinnerLabel="Installing on your device..."
/>
</main>
<AndroidSetupSpinnerStep
deps={props.deps}
spinnerLabel="Installing on your device..."
/>
);
},
);
Original file line number Diff line number Diff line change
@@ -1,19 +1,17 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`DetectDevicesStep renders 1`] = `
<main>
<AndroidSetupSpinnerStep
deps={
Object {
"LinkComponent": [Function],
"androidSetupActionCreator": null,
"androidSetupStepComponentProvider": null,
"closeApp": null,
"showOpenFileDialog": null,
"startTesting": null,
}
<AndroidSetupSpinnerStep
deps={
Object {
"LinkComponent": [Function],
"androidSetupActionCreator": null,
"androidSetupStepComponentProvider": null,
"closeApp": null,
"showOpenFileDialog": null,
"startTesting": null,
}
spinnerLabel="Scanning for devices..."
/>
</main>
}
spinnerLabel="Scanning for devices..."
/>
`;
Original file line number Diff line number Diff line change
@@ -1,19 +1,17 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`DetectDevicesStep renders 1`] = `
<main>
<AndroidSetupSpinnerStep
deps={
Object {
"LinkComponent": [Function],
"androidSetupActionCreator": null,
"androidSetupStepComponentProvider": null,
"closeApp": null,
"showOpenFileDialog": null,
"startTesting": null,
}
<AndroidSetupSpinnerStep
deps={
Object {
"LinkComponent": [Function],
"androidSetupActionCreator": null,
"androidSetupStepComponentProvider": null,
"closeApp": null,
"showOpenFileDialog": null,
"startTesting": null,
}
spinnerLabel="Checking permissions..."
/>
</main>
}
spinnerLabel="Checking permissions..."
/>
`;
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`DetectServiceStep renders 1`] = `
<main>
<AndroidSetupSpinnerStep
deps={
Object {
"LinkComponent": [Function],
"androidSetupActionCreator": null,
"androidSetupStepComponentProvider": null,
"closeApp": null,
"showOpenFileDialog": null,
"startTesting": null,
}
<AndroidSetupSpinnerStep
deps={
Object {
"LinkComponent": [Function],
"androidSetupActionCreator": null,
"androidSetupStepComponentProvider": null,
"closeApp": null,
"showOpenFileDialog": null,
"startTesting": null,
}
disableCancel={true}
spinnerLabel="Scanning for devices..."
/>
</main>
}
disableCancel={true}
spinnerLabel="Scanning for devices..."
/>
`;
Original file line number Diff line number Diff line change
@@ -1,19 +1,17 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`InstallingServiceStep renders 1`] = `
<main>
<AndroidSetupSpinnerStep
deps={
Object {
"LinkComponent": [Function],
"androidSetupActionCreator": null,
"androidSetupStepComponentProvider": null,
"closeApp": null,
"showOpenFileDialog": null,
"startTesting": null,
}
<AndroidSetupSpinnerStep
deps={
Object {
"LinkComponent": [Function],
"androidSetupActionCreator": null,
"androidSetupStepComponentProvider": null,
"closeApp": null,
"showOpenFileDialog": null,
"startTesting": null,
}
spinnerLabel="Installing on your device..."
/>
</main>
}
spinnerLabel="Installing on your device..."
/>
`;