Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more electron framework tests for release builds #4272

Merged
merged 2 commits into from
May 24, 2021

Conversation

karanbirsingh
Copy link
Contributor

@karanbirsingh karanbirsingh commented May 24, 2021

Details

In this PR:

  • we verify that the electron version and mirror build ID are updated in lockstep (to avoid forgetting the build ID)
  • we verify that the executable's electron build ID (found in process.versions) matches what we expect

The update process looks the same, although the assetNumber is moved to its own standalone file.

Motivation

This builds on PRs like #2749 and #2604 to improve the electron-upgrade process.

validation run

see question at https://github.com/microsoft/accessibility-insights-web/pull/4272/files#r638299525

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@karanbirsingh karanbirsingh requested a review from a team as a code owner May 24, 2021 21:40
},
);

it('electron versions in package.json and build id are updated together', async () => {
Copy link
Contributor Author

@karanbirsingh karanbirsingh May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about running this only in PR builds, but I'm not sure. On one hand it'll simplify electron prototyping locally (otherwise folks will need to comment out), but on the other it'll defer issues until PR-time.

@karanbirsingh karanbirsingh merged commit b6766bd into main May 24, 2021
@karanbirsingh karanbirsingh deleted the karansin/electron-test branch May 24, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants