Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Red failure color in overlays #4948

Merged
merged 23 commits into from
Dec 1, 2021

Conversation

ThanyaLeif
Copy link
Contributor

@ThanyaLeif ThanyaLeif commented Dec 1, 2021

Details

This PR updates the color of the highlighted elements in FastPass, to match the red used within the Accessibility Insights UI and reports for both FastPass and Assessments.

Previously the elements in FastPass were color rgb(204, 0, 0), after this PR the elements are colored rgb(232, 17, 35) matching the rest of the UI.

Motivation

Addresses issue #4911

Context

Screenshots of changes in affected areas:

Before changes
image
The image above shows FastPass results page with highlighted elements in HEX #CC0000 (rgb (204,0,0))
After changes
image
The image above shows FastPass results page with highlighted elements in HEX #E81123 (rgb(232, 17, 35))

Pull request checklist

  • Addresses an existing issue: Red failure color in overlays vs. FastPass, Assessments, reports UI #4911
  • Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@ThanyaLeif ThanyaLeif requested a review from a team as a code owner December 1, 2021 18:19
Copy link
Contributor

@jlperkins jlperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@ThanyaLeif ThanyaLeif merged commit 81ebfb1 into microsoft:main Dec 1, 2021
@ThanyaLeif ThanyaLeif deleted the users/tania/red-color-bug branch December 1, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants