-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Red failure color in overlays #4948
Merged
ThanyaLeif
merged 23 commits into
microsoft:main
from
ThanyaLeif:users/tania/red-color-bug
Dec 1, 2021
Merged
fix: Red failure color in overlays #4948
ThanyaLeif
merged 23 commits into
microsoft:main
from
ThanyaLeif:users/tania/red-color-bug
Dec 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlperkins
reviewed
Dec 1, 2021
src/tests/unit/tests/injected/visualization/highlight-box-formatter.test.ts
Outdated
Show resolved
Hide resolved
jlperkins
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR updates the color of the highlighted elements in FastPass, to match the red used within the Accessibility Insights UI and reports for both FastPass and Assessments.
Previously the elements in FastPass were color
rgb(204, 0, 0)
, after this PR the elements are coloredrgb(232, 17, 35)
matching the rest of the UI.Motivation
Addresses issue #4911
Context
Screenshots of changes in affected areas:
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.