Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Red failure color in overlays #4948

Merged
merged 23 commits into from
Dec 1, 2021
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/content/test/headings/no-missing-headings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ export const infoAndExamples = create(({ Markup, Link }) => (
<h2>Example</h2>
<Markup.PassFail
failText={<p>This element looks like a heading, but it isn't coded as a heading.</p>}
failExample={`[<p style="font-size:2em; font-weight:700;] color:#cc0000">About Accessibility Insights for Web</p>`}
failExample={`[<p style="font-size:2em; font-weight:700;] color:#e81123">About Accessibility Insights for Web</p>`}
passText={<p>The element is coded as a heading.</p>}
passExample={`[<h1 ]style="color:#cc0000">About Accessibility Insights for Web[</h1>]`}
passExample={`[<h1 ]style="color:#e81123">About Accessibility Insights for Web[</h1>]`}
/>
<h2>More examples</h2>
<h3>WCAG success criteria</h3>
Expand Down
2 changes: 1 addition & 1 deletion src/injected/visualization/failure-instance-formatter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { FailureBoxConfig, Formatter } from './formatter';

export abstract class FailureInstanceFormatter implements Formatter {
public static failureBoxConfig: FailureBoxConfig = {
background: '#CC0000',
background: '#E81123',
fontColor: '#FFFFFF',
text: '!',
boxWidth: '20px',
Expand Down
2 changes: 1 addition & 1 deletion src/injected/visualization/issues-formatter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class IssuesFormatter implements Formatter {
}

public static style: HeadingStyleConfiguration = {
borderColor: '#CC0000',
borderColor: '#E81123',
fontColor: '#FFFFFF',
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12104,7 +12104,7 @@ exports[`Guidance Content pages test/headings/noMissingHeadings/infoAndExamples
>
&lt;p style="font-size:2em; font-weight:700;
</span>
color:#cc0000"&gt;About Accessibility Insights for Web&lt;/p&gt;
color:#e81123"&gt;About Accessibility Insights for Web&lt;/p&gt;
</div>
</div>
</div>
Expand Down Expand Up @@ -12165,7 +12165,7 @@ exports[`Guidance Content pages test/headings/noMissingHeadings/infoAndExamples
>
&lt;h1
</span>
style="color:#cc0000"&gt;About Accessibility Insights for Web
style="color:#e81123"&gt;About Accessibility Insights for Web
<span
class="highlight"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ describe('HeadingFormatterTests', () => {
function verifyFailureBoxStyle(config: DrawerConfiguration): void {
const failureBoxConfig = config.failureBoxConfig;
const expected = {
background: '#CC0000',
background: '#E81123',
fontColor: '#FFFFFF',
text: '!',
boxWidth: '20px',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe('HighlightBoxFormatterTests', () => {

expect(config.showVisualization).toBe(true);
expect(config.failureBoxConfig).toBeNull();
expect(config.borderColor).toEqual('#CC0000');
expect(config.borderColor).toEqual('#e81123');
ThanyaLeif marked this conversation as resolved.
Show resolved Hide resolved
expect(config.textAlign).toEqual('center');
});

Expand Down